evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Issue #555] Leaving square brackets unescaped in query string parameters

Browse source
This commit is contained in:
Mattt Thompson 2012-10-03 08:49:39 -07:00
parent f9c0576f89
commit 3f3a79221a
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
AFNetworking/AFHTTPClient.m
View file

@ -88,10 +88,10 @@ static NSString * AFBase64EncodedStringFromString(NSString *string) {
} }
static NSString * AFPercentEscapedQueryStringPairMemberFromStringWithEncoding(NSString *string, NSStringEncoding encoding) { static NSString * AFPercentEscapedQueryStringPairMemberFromStringWithEncoding(NSString *string, NSStringEncoding encoding) {
// Escape characters that are legal in URIs, but have unintentional semantic significance when used in a query string parameter static NSString * const kAFCharactersToBeEscaped = @":/.?&=;+!@#$()~";
static NSString * const kAFLegalCharactersToBeEscaped = @":/.?&=;+!@$()~"; static NSString * const kAFCharactersToLeaveUnescaped = @"[]";
return (__bridge_transfer NSString *)CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (__bridge CFStringRef)string, NULL, (__bridge CFStringRef)kAFLegalCharactersToBeEscaped, CFStringConvertNSStringEncodingToEncoding(encoding)); return (__bridge_transfer NSString *)CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (__bridge CFStringRef)string, (__bridge CFStringRef)kAFCharactersToLeaveUnescaped, (__bridge CFStringRef)kAFCharactersToBeEscaped, CFStringConvertNSStringEncodingToEncoding(encoding));
} }
#pragma mark - #pragma mark -
@ -237,7 +237,7 @@ static NSString * AFPropertyListStringFromParameters(NSDictionary *parameters) {
if (!self) { if (!self) {
return nil; return nil;
} }
// Ensure terminal slash for baseURL path, so that NSURL +URLWithString:relativeToURL: works as expected // Ensure terminal slash for baseURL path, so that NSURL +URLWithString:relativeToURL: works as expected
if ([[url path] length] > 0 && ![[url absoluteString] hasSuffix:@"/"]) { if ([[url path] length] > 0 && ![[url absoluteString] hasSuffix:@"/"]) {
url = [url URLByAppendingPathComponent:@""]; url = [url URLByAppendingPathComponent:@""];