evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Issue #469] Optimizing calculation of finished operations in batch progress callback

Browse source
This commit is contained in:
Mattt Thompson 2012-08-22 11:31:49 -07:00
parent 2d7b2f35d6
commit 706fbe473d
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
AFNetworking/AFHTTPClient.m
View file

@ -585,8 +585,6 @@ static void AFNetworkReachabilityReleaseCallback(const void *info) {
dispatch_release(dispatchGroup); dispatch_release(dispatchGroup);
}]; }];
NSPredicate *finishedOperationPredicate = [NSPredicate predicateWithFormat:@"isFinished == YES"];
for (AFHTTPRequestOperation *operation in operations) { for (AFHTTPRequestOperation *operation in operations) {
AFCompletionBlock originalCompletionBlock = [[operation.completionBlock copy] autorelease]; AFCompletionBlock originalCompletionBlock = [[operation.completionBlock copy] autorelease];
operation.completionBlock = ^{ operation.completionBlock = ^{
@ -596,8 +594,15 @@ static void AFNetworkReachabilityReleaseCallback(const void *info) {
originalCompletionBlock(); originalCompletionBlock();
} }
__block NSUInteger numberOfCompletedOperations = 0;
[operations enumerateObjectsUsingBlock:^(id obj, NSUInteger idx, BOOL *stop) {
if ([(NSOperation *)obj isFinished]) {
numberOfCompletedOperations++;
}
}];
if (progressBlock) { if (progressBlock) {
progressBlock([[operations filteredArrayUsingPredicate:finishedOperationPredicate] count], [operations count]); progressBlock(numberOfCompletedOperations, [operations count]);
} }
dispatch_group_leave(dispatchGroup); dispatch_group_leave(dispatchGroup);