evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Issue #398] Adding state checks to AFURLConnectionOperation -pause to prevent likely memry issues when cancelling a non-existint connection

Browse source
This commit is contained in:
Mattt Thompson 2012-07-23 16:20:11 -07:00
parent 9236e41850
commit 70787ce4cf
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
AFNetworking/AFURLConnectionOperation.m
View file

@ -355,15 +355,19 @@ static inline BOOL AFStateTransitionIsValid(AFOperationState fromState, AFOperat
} }
- (void)pause { - (void)pause {
if ([self isPaused]) { if ([self isPaused] || [self isFinished]) {
return; return;
} }
[self.lock lock]; [self.lock lock];
self.state = AFHTTPOperationPausedState;
[self.connection performSelector:@selector(cancel) onThread:[[self class] networkRequestThread] withObject:nil waitUntilDone:NO modes:[self.runLoopModes allObjects]]; if ([self isExecuting]) {
[[NSNotificationCenter defaultCenter] postNotificationName:AFNetworkingOperationDidFinishNotification object:self]; [self.connection performSelector:@selector(cancel) onThread:[[self class] networkRequestThread] withObject:nil waitUntilDone:NO modes:[self.runLoopModes allObjects]];
[[NSNotificationCenter defaultCenter] postNotificationName:AFNetworkingOperationDidFinishNotification object:self];
}
self.state = AFHTTPOperationPausedState;
[self.lock unlock]; [self.lock unlock];
} }