From a9123824312753d5aad10a892614c3d5cd7a70ee Mon Sep 17 00:00:00 2001 From: Mattt Thompson Date: Tue, 22 Nov 2011 20:57:39 -0600 Subject: [PATCH] Changing connection property from retain to assign, to avoid retain cycle caused by NSURLConnection retaining its delegate --- AFNetworking/AFURLConnectionOperation.m | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/AFNetworking/AFURLConnectionOperation.m b/AFNetworking/AFURLConnectionOperation.m index 3869bb9..5b39c22 100644 --- a/AFNetworking/AFURLConnectionOperation.m +++ b/AFNetworking/AFURLConnectionOperation.m @@ -54,7 +54,7 @@ static inline NSString * AFKeyPathFromOperationState(AFOperationState state) { @interface AFURLConnectionOperation () @property (readwrite, nonatomic, assign) AFOperationState state; @property (readwrite, nonatomic, assign, getter = isCancelled) BOOL cancelled; -@property (readwrite, nonatomic, retain) NSURLConnection *connection; +@property (readwrite, nonatomic, assign) NSURLConnection *connection; @property (readwrite, nonatomic, retain) NSURLRequest *request; @property (readwrite, nonatomic, retain) NSURLResponse *response; @property (readwrite, nonatomic, retain) NSError *error; @@ -133,9 +133,7 @@ static inline NSString * AFKeyPathFromOperationState(AFOperationState state) { [_responseString release]; [_dataAccumulator release]; [_outputStream release]; _outputStream = nil; - - [_connection release]; _connection = nil; - + [_uploadProgress release]; [_downloadProgress release];