evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixing warnings triggered by -Weverything flag

Browse source 
Explicitly covering all enum values in switch statements

Removing unused, unsynthesized properties

Adding missing synthesizers for properties

Fixing misuse of compiler macro
This commit is contained in:
Mattt Thompson 2012-10-01 10:45:43 -07:00
parent d933fe60e7
commit b317c7d5d9
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
AFNetworking/AFHTTPClient.m
View file

@ -551,7 +551,7 @@ static void AFNetworkReachabilityReleaseCallback(const void *info) {}
completionBlock(operations); completionBlock(operations);
} }
}); });
#if AF_DISPATCH_RETAIN_RELEASE #ifdef AF_DISPATCH_RETAIN_RELEASE
dispatch_release(dispatchGroup); dispatch_release(dispatchGroup);
#endif #endif
}]; }];
@ -877,8 +877,6 @@ NSUInteger const kAFUploadStream3GSuggestedDelay = 0.2;
@property (nonatomic, retain) NSMutableArray *HTTPBodyParts; @property (nonatomic, retain) NSMutableArray *HTTPBodyParts;
@property (nonatomic, retain) NSEnumerator *HTTPBodyPartEnumerator; @property (nonatomic, retain) NSEnumerator *HTTPBodyPartEnumerator;
@property (nonatomic, retain) AFHTTPBodyPart *currentHTTPBodyPart; @property (nonatomic, retain) AFHTTPBodyPart *currentHTTPBodyPart;
@property (nonatomic, retain) NSDate *lastReadAt;
@property (nonatomic, assign) NSInteger lastBytesRead;
@end @end
@implementation AFMultipartBodyStream @implementation AFMultipartBodyStream
@ -1040,6 +1038,8 @@ typedef enum {
@synthesize headers = _headers; @synthesize headers = _headers;
@synthesize bodyContentLength = _bodyContentLength; @synthesize bodyContentLength = _bodyContentLength;
@synthesize inputStream = _inputStream; @synthesize inputStream = _inputStream;
@synthesize hasInitialBoundary = _hasInitialBoundary;
@synthesize hasFinalBoundary = _hasFinalBoundary;
- (id)init { - (id)init {
self = [super init]; self = [super init];
@ -1088,12 +1088,16 @@ typedef enum {
- (BOOL)hasBytesAvailable { - (BOOL)hasBytesAvailable {
switch (self.inputStream.streamStatus) { switch (self.inputStream.streamStatus) {
case NSStreamStatusOpen:
case NSStreamStatusReading:
case NSStreamStatusWriting:
return YES;
case NSStreamStatusNotOpen:
case NSStreamStatusOpening:
case NSStreamStatusAtEnd: case NSStreamStatusAtEnd:
case NSStreamStatusClosed: case NSStreamStatusClosed:
case NSStreamStatusError: case NSStreamStatusError:
return NO; return NO;
default:
return YES;
} }
} }
@ -1163,7 +1167,7 @@ typedef enum {
[self.inputStream close]; [self.inputStream close];
_phase = AFFinalBoundaryPhase; _phase = AFFinalBoundaryPhase;
break; break;
default: case AFFinalBoundaryPhase:
_phase = AFEncapsulationBoundaryPhase; _phase = AFEncapsulationBoundaryPhase;
break; break;
} }