evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The allocation for the shared client could occur twice resulting in a leak. Two

Browse source 
threads could pass the nil check. One would acquire the lock and create the
sharedClient. The second thread would eventually get the lock and also acquire
a sharedClient.
This commit is contained in:
Evan Long 2011-09-15 00:58:41 -07:00
parent 8d9b7ace34
commit b681971116
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Example/Classes/AFGowallaAPIClient.m
View file

@ -32,11 +32,10 @@ NSString * const kAFGowallaBaseURLString = @"https://api.gowalla.com/";
@implementation AFGowallaAPIClient @implementation AFGowallaAPIClient
+ (id)sharedClient { + (id)sharedClient {
if (_sharedClient == nil) { static dispatch_once_t oncePredicate;
@synchronized(self) { dispatch_once(&oncePredicate, ^{
_sharedClient = [[self alloc] init]; _sharedClient = [[self alloc] init];
} });
}
return _sharedClient; return _sharedClient;
} }