[Issue #65] Adding slight delay when hiding network activity indicator, to avoid flickering

AFNetworking/AFNetworkActivityIndicatorManager.h

@@ -29,6 +29,7 @@
 @private
 	NSInteger _activityCount;
     BOOL _enabled;
+    NSTimer *_activityIndicatorVisibilityTimer;
 }
 
 /**

AFNetworking/AFNetworkActivityIndicatorManager.m

@@ -24,13 +24,21 @@
 
 #import "AFHTTPRequestOperation.h"
 
+static NSTimeInterval const kAFNetworkActivityIndicatorInvisibilityDelay = 0.25;
+
 @interface AFNetworkActivityIndicatorManager ()
 @property (readwrite, nonatomic, assign) NSInteger activityCount;
+@property (readwrite, nonatomic, retain) NSTimer *activityIndicatorVisibilityTimer;
+@property (readonly, getter = isNetworkActivityIndicatorVisible) BOOL networkActivityIndicatorVisible;
+
+- (void)updateNetworkActivityIndicatorVisibility;
 @end
 
 @implementation AFNetworkActivityIndicatorManager
 @synthesize activityCount = _activityCount;
+@synthesize activityIndicatorVisibilityTimer = _activityIndicatorVisibilityTimer;
 @synthesize enabled = _enabled;
+@dynamic networkActivityIndicatorVisible;
 
 + (AFNetworkActivityIndicatorManager *)sharedManager {
     static AFNetworkActivityIndicatorManager *_sharedManager = nil;
@@ -57,6 +65,9 @@
 - (void)dealloc {
     [[NSNotificationCenter defaultCenter] removeObserver:self];
     
+    [_activityIndicatorVisibilityTimer invalidate];
+    [_activityIndicatorVisibilityTimer release]; _activityIndicatorVisibilityTimer = nil;
+    
     [super dealloc];
 }
 
@@ -66,9 +77,24 @@
     [self didChangeValueForKey:@"activityCount"];
 
     if (self.enabled) {
-        [[UIApplication sharedApplication] setNetworkActivityIndicatorVisible:self.activityCount > 0];
+        // Delay hiding of activity indicator for a short interval, to avoid flickering
+        if (![self isNetworkActivityIndicatorVisible]) {
+            [self.activityIndicatorVisibilityTimer invalidate];
+            self.activityIndicatorVisibilityTimer = [NSTimer timerWithTimeInterval:kAFNetworkActivityIndicatorInvisibilityDelay target:self selector:@selector(updateNetworkActivityIndicatorVisibility) userInfo:nil repeats:NO];
+            [[NSRunLoop currentRunLoop] addTimer:self.activityIndicatorVisibilityTimer forMode:NSRunLoopCommonModes];
+        } else {
+            [self updateNetworkActivityIndicatorVisibility];
         }
     }
+}
+
+- (BOOL)isNetworkActivityIndicatorVisible {
+    return self.activityCount > 0;
+}
+
+- (void)updateNetworkActivityIndicatorVisibility {
+    [[UIApplication sharedApplication] setNetworkActivityIndicatorVisible:[self isNetworkActivityIndicatorVisible]];
+}
 
 - (void)incrementActivityCount {
     @synchronized(self) {