From cdbae5a9fbb6d6cec795d981b055878f340dbd0b Mon Sep 17 00:00:00 2001 From: Tony Million Date: Fri, 31 Aug 2012 09:27:43 +0100 Subject: [PATCH] tests self.response before blindy returning 200 in hasAcceptableStatusCode if self.response is nil then network failure is assumed --- AFNetworking/AFHTTPRequestOperation.m | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/AFNetworking/AFHTTPRequestOperation.m b/AFNetworking/AFHTTPRequestOperation.m index 31efc4d..2539d3a 100644 --- a/AFNetworking/AFHTTPRequestOperation.m +++ b/AFNetworking/AFHTTPRequestOperation.m @@ -173,7 +173,12 @@ static NSString * AFStringFromIndexSet(NSIndexSet *indexSet) { } - (BOOL)hasAcceptableStatusCode { - NSUInteger statusCode = ([self.response isKindOfClass:[NSHTTPURLResponse class]]) ? (NSUInteger)[self.response statusCode] : 0; + if(!self.response) { + // no response means network failure or such + return NO; + } + + NSUInteger statusCode = ([self.response isKindOfClass:[NSHTTPURLResponse class]]) ? (NSUInteger)[self.response statusCode] : 200; return ![[self class] acceptableStatusCodes] || [[[self class] acceptableStatusCodes] containsIndex:statusCode]; }