evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

protect decrementActivityCount against integer underflow.

Browse source
This commit is contained in:
Peter Steinberger 2012-04-05 17:49:08 -07:00
parent 069615a20d
commit e2751e6ffc
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
AFNetworking/AFNetworkActivityIndicatorManager.m
View file

@ -111,7 +111,11 @@ static NSTimeInterval const kAFNetworkActivityIndicatorInvisibilityDelay = 0.25;
- (void)decrementActivityCount { - (void)decrementActivityCount {
[self willChangeValueForKey:@"activityCount"]; [self willChangeValueForKey:@"activityCount"];
OSAtomicDecrement32((int32_t*)&_activityCount); bool success;
do {
int32_t orig = _activityCount;
success = OSAtomicCompareAndSwap32(orig, MIN(orig - 1, orig), &_activityCount);
} while(!success);
[self didChangeValueForKey:@"activityCount"]; [self didChangeValueForKey:@"activityCount"];
[self updateNetworkActivityIndicatorVisibilityDelayed]; [self updateNetworkActivityIndicatorVisibilityDelayed];
} }