Replacing existing property ownership values of retain with strong

This commit is contained in:
Mattt Thompson 2012-10-09 09:26:50 -07:00
parent cd2171cc5c
commit e8b3e27043
7 changed files with 20 additions and 28 deletions

View file

@ -90,13 +90,12 @@ static NSString * AFPercentEscapedQueryStringPairMemberFromStringWithEncoding(NS
#pragma mark - #pragma mark -
@interface AFQueryStringPair : NSObject @interface AFQueryStringPair : NSObject
@property (readwrite, nonatomic, retain) id field; @property (readwrite, nonatomic, strong) id field;
@property (readwrite, nonatomic, retain) id value; @property (readwrite, nonatomic, strong) id value;
- (id)initWithField:(id)field value:(id)value; - (id)initWithField:(id)field value:(id)value;
- (NSString *)URLEncodedStringValueWithEncoding:(NSStringEncoding)stringEncoding; - (NSString *)URLEncodedStringValueWithEncoding:(NSStringEncoding)stringEncoding;
@end @end
@implementation AFQueryStringPair @implementation AFQueryStringPair
@ -185,12 +184,10 @@ static NSString * AFPropertyListStringFromParameters(NSDictionary *parameters) {
} }
@interface AFStreamingMultipartFormData : NSObject <AFMultipartFormData> @interface AFStreamingMultipartFormData : NSObject <AFMultipartFormData>
- (id)initWithURLRequest:(NSMutableURLRequest *)request - (id)initWithURLRequest:(NSMutableURLRequest *)request
stringEncoding:(NSStringEncoding)encoding; stringEncoding:(NSStringEncoding)encoding;
- (NSMutableURLRequest *)requestByFinalizingMultipartFormData; - (NSMutableURLRequest *)requestByFinalizingMultipartFormData;
@end @end
#pragma mark - #pragma mark -
@ -733,10 +730,9 @@ NSUInteger const kAFUploadStream3GSuggestedPacketSize = 1024 * 16;
NSTimeInterval const kAFUploadStream3GSuggestedDelay = 0.2; NSTimeInterval const kAFUploadStream3GSuggestedDelay = 0.2;
@interface AFHTTPBodyPart : NSObject @interface AFHTTPBodyPart : NSObject
@property (nonatomic, assign) NSStringEncoding stringEncoding; @property (nonatomic, assign) NSStringEncoding stringEncoding;
@property (nonatomic, retain) NSDictionary *headers; @property (nonatomic, strong) NSDictionary *headers;
@property (nonatomic, retain) NSInputStream *inputStream; @property (nonatomic, strong) NSInputStream *inputStream;
@property (nonatomic, assign) unsigned long long bodyContentLength; @property (nonatomic, assign) unsigned long long bodyContentLength;
@property (nonatomic, assign) BOOL hasInitialBoundary; @property (nonatomic, assign) BOOL hasInitialBoundary;
@ -746,11 +742,9 @@ NSTimeInterval const kAFUploadStream3GSuggestedDelay = 0.2;
@property (readonly) unsigned long long contentLength; @property (readonly) unsigned long long contentLength;
- (NSInteger)read:(uint8_t *)buffer maxLength:(NSUInteger)length; - (NSInteger)read:(uint8_t *)buffer maxLength:(NSUInteger)length;
@end @end
@interface AFMultipartBodyStream : NSInputStream <NSStreamDelegate> @interface AFMultipartBodyStream : NSInputStream <NSStreamDelegate>
@property (nonatomic, assign) NSUInteger numberOfBytesInPacket; @property (nonatomic, assign) NSUInteger numberOfBytesInPacket;
@property (nonatomic, assign) NSTimeInterval delay; @property (nonatomic, assign) NSTimeInterval delay;
@property (readonly) unsigned long long contentLength; @property (readonly) unsigned long long contentLength;
@ -759,14 +753,13 @@ NSTimeInterval const kAFUploadStream3GSuggestedDelay = 0.2;
- (id)initWithStringEncoding:(NSStringEncoding)encoding; - (id)initWithStringEncoding:(NSStringEncoding)encoding;
- (void)setInitialAndFinalBoundaries; - (void)setInitialAndFinalBoundaries;
- (void)appendHTTPBodyPart:(AFHTTPBodyPart *)bodyPart; - (void)appendHTTPBodyPart:(AFHTTPBodyPart *)bodyPart;
@end @end
#pragma mark - #pragma mark -
@interface AFStreamingMultipartFormData () @interface AFStreamingMultipartFormData ()
@property (readwrite, nonatomic, copy) NSMutableURLRequest *request; @property (readwrite, nonatomic, copy) NSMutableURLRequest *request;
@property (readwrite, nonatomic, retain) AFMultipartBodyStream *bodyStream; @property (readwrite, nonatomic, strong) AFMultipartBodyStream *bodyStream;
@property (readwrite, nonatomic, assign) NSStringEncoding stringEncoding; @property (readwrite, nonatomic, assign) NSStringEncoding stringEncoding;
@end @end
@ -897,12 +890,12 @@ NSTimeInterval const kAFUploadStream3GSuggestedDelay = 0.2;
@interface AFMultipartBodyStream () @interface AFMultipartBodyStream ()
@property (nonatomic, assign) NSStreamStatus streamStatus; @property (nonatomic, assign) NSStreamStatus streamStatus;
@property (nonatomic, retain) NSError *streamError; @property (nonatomic, strong) NSError *streamError;
@property (nonatomic, assign) NSStringEncoding stringEncoding; @property (nonatomic, assign) NSStringEncoding stringEncoding;
@property (nonatomic, retain) NSMutableArray *HTTPBodyParts; @property (nonatomic, strong) NSMutableArray *HTTPBodyParts;
@property (nonatomic, retain) NSEnumerator *HTTPBodyPartEnumerator; @property (nonatomic, strong) NSEnumerator *HTTPBodyPartEnumerator;
@property (nonatomic, retain) AFHTTPBodyPart *currentHTTPBodyPart; @property (nonatomic, strong) AFHTTPBodyPart *currentHTTPBodyPart;
@end @end
@implementation AFMultipartBodyStream @implementation AFMultipartBodyStream
@ -1056,7 +1049,6 @@ typedef enum {
} }
- (BOOL)transitionToNextPhase; - (BOOL)transitionToNextPhase;
@end @end
@implementation AFHTTPBodyPart @implementation AFHTTPBodyPart

View file

@ -55,9 +55,9 @@
An image constructed from the response data. If an error occurs during the request, `nil` will be returned, and the `error` property will be set to the error. An image constructed from the response data. If an error occurs during the request, `nil` will be returned, and the `error` property will be set to the error.
*/ */
#if __IPHONE_OS_VERSION_MIN_REQUIRED #if __IPHONE_OS_VERSION_MIN_REQUIRED
@property (readonly, nonatomic) UIImage *responseImage; @property (readonly, nonatomic, strong) UIImage *responseImage;
#elif __MAC_OS_X_VERSION_MIN_REQUIRED #elif __MAC_OS_X_VERSION_MIN_REQUIRED
@property (readonly, nonatomic, retain) NSImage *responseImage; @property (readonly, nonatomic, strong) NSImage *responseImage;
#endif #endif
#if __IPHONE_OS_VERSION_MIN_REQUIRED #if __IPHONE_OS_VERSION_MIN_REQUIRED

View file

@ -33,9 +33,9 @@ static dispatch_queue_t image_request_operation_processing_queue() {
@interface AFImageRequestOperation () @interface AFImageRequestOperation ()
#if __IPHONE_OS_VERSION_MIN_REQUIRED #if __IPHONE_OS_VERSION_MIN_REQUIRED
@property (readwrite, nonatomic) UIImage *responseImage; @property (readwrite, nonatomic, strong) UIImage *responseImage;
#elif __MAC_OS_X_VERSION_MIN_REQUIRED #elif __MAC_OS_X_VERSION_MIN_REQUIRED
@property (readwrite, nonatomic, retain) NSImage *responseImage; @property (readwrite, nonatomic, strong) NSImage *responseImage;
#endif #endif
@end @end

View file

@ -29,7 +29,7 @@ static NSTimeInterval const kAFNetworkActivityIndicatorInvisibilityDelay = 0.17;
@interface AFNetworkActivityIndicatorManager () @interface AFNetworkActivityIndicatorManager ()
@property (readwrite, assign) NSInteger activityCount; @property (readwrite, assign) NSInteger activityCount;
@property (readwrite, nonatomic, retain) NSTimer *activityIndicatorVisibilityTimer; @property (readwrite, nonatomic, strong) NSTimer *activityIndicatorVisibilityTimer;
@property (readonly, getter = isNetworkActivityIndicatorVisible) BOOL networkActivityIndicatorVisible; @property (readonly, getter = isNetworkActivityIndicatorVisible) BOOL networkActivityIndicatorVisible;
- (void)updateNetworkActivityIndicatorVisibility; - (void)updateNetworkActivityIndicatorVisibility;

View file

@ -48,13 +48,13 @@
/** /**
An `NSXMLParser` object constructed from the response data. An `NSXMLParser` object constructed from the response data.
*/ */
@property (readonly, nonatomic) NSXMLParser *responseXMLParser; @property (readonly, nonatomic, strong) NSXMLParser *responseXMLParser;
#ifdef __MAC_OS_X_VERSION_MIN_REQUIRED #ifdef __MAC_OS_X_VERSION_MIN_REQUIRED
/** /**
An `NSXMLDocument` object constructed from the response data. If an error occurs while parsing, `nil` will be returned, and the `error` property will be set to the error. An `NSXMLDocument` object constructed from the response data. If an error occurs while parsing, `nil` will be returned, and the `error` property will be set to the error.
*/ */
@property (readonly, nonatomic, retain) NSXMLDocument *responseXMLDocument; @property (readonly, nonatomic, strong) NSXMLDocument *responseXMLDocument;
#endif #endif
/** /**

View file

@ -34,11 +34,11 @@ static dispatch_queue_t xml_request_operation_processing_queue() {
} }
@interface AFXMLRequestOperation () @interface AFXMLRequestOperation ()
@property (readwrite, nonatomic) NSXMLParser *responseXMLParser; @property (readwrite, nonatomic, strong) NSXMLParser *responseXMLParser;
#ifdef __MAC_OS_X_VERSION_MIN_REQUIRED #ifdef __MAC_OS_X_VERSION_MIN_REQUIRED
@property (readwrite, nonatomic, retain) NSXMLDocument *responseXMLDocument; @property (readwrite, nonatomic, strong) NSXMLDocument *responseXMLDocument;
#endif #endif
@property (readwrite, nonatomic) NSError *XMLError; @property (readwrite, nonatomic, strong) NSError *XMLError;
@end @end
@implementation AFXMLRequestOperation @implementation AFXMLRequestOperation

View file

@ -37,7 +37,7 @@
static char kAFImageRequestOperationObjectKey; static char kAFImageRequestOperationObjectKey;
@interface UIImageView (_AFNetworking) @interface UIImageView (_AFNetworking)
@property (readwrite, nonatomic, retain, setter = af_setImageRequestOperation:) AFImageRequestOperation *af_imageRequestOperation; @property (readwrite, nonatomic, strong, setter = af_setImageRequestOperation:) AFImageRequestOperation *af_imageRequestOperation;
@end @end
@implementation UIImageView (_AFNetworking) @implementation UIImageView (_AFNetworking)