Commit graph

948 commits

Author SHA1 Message Date
Mattt Thompson
782862bd6f [Issue #449] Fixing bug where tempfiles for multipart form message bodies could collide, specifically for requests with the same URL 2012-08-12 19:08:58 -04:00
bratley Lower
59ef3550d5 add accept header for set uiimage by url 2012-08-12 09:52:31 -05:00
Mattt Thompson
30e4b952b9 Merge pull request #452 from steipete/experimental-1.0RC2
don't use __weak for completionBlocks. (Issue #414)
2012-08-11 11:32:12 -07:00
Mattt Thompson
481033ae0c Minor code reformatting and inline documentation 2012-08-11 14:26:03 -04:00
Mattt Thompson
a83712c1f0 Merge branch 'patch-8' of git://github.com/tewha/AFNetworking into tewha-patch-8 2012-08-11 14:20:19 -04:00
Mattt Thompson
3d6fcc35c9 Moving error alert logic from models to controllers 2012-08-11 11:16:55 -04:00
Mattt Thompson
fbc4ec5dbd Adding responseString as NSLocalizedRecoverySuggestionErrorKey in errors for unacceptable content type and status code 2012-08-11 11:12:02 -04:00
Steven Fisher
f849627f9a initWithBaseURL
Fixes 446. If the URL passed into initWithBaseURL is a file URL rather
than a directory URL we will fix it.

Without this fix, if you provide "http://myhost/api" as a baseURL and
try to get "path", AFNetworking will get http://myhost/path instead of
http://myhost/api/path. With the fix, we'll change http://myhost/api to
http://myhost/api/.
2012-08-08 11:07:20 -07:00
Mattt Thompson
bff368c096 Using NSOperationQueueDefaultMaxConcurrentOperationCount rather than previously-specified constant (k=4) 2012-08-06 17:30:01 -04:00
Mattt Thompson
5cac0fea1b Removing leftover methods and functions from download operation patch 2012-08-06 17:22:34 -04:00
Mattt Thompson
b494bfe3fb Adding NSURLConnection delegate method declarations in the AFURLConnection header to allow subclasses to call out to super implementation. Will be removed in 1.0, since iOS 5 / Mac OS 10.7 defined these as a formal protocol. 2012-08-04 15:48:01 -04:00
Mattt Thompson
c9680e1246 [Issue #411] Dispatching upload/download progress blocks to the main queue 2012-08-04 15:34:09 -04:00
Mattt Thompson
d02d9612dd Changing string format replacement tokens to suppress compiler warnings 2012-08-04 15:29:00 -04:00
Mattt Thompson
4809c77427 Updating project settings for Xcode 4.4 2012-08-04 15:28:32 -04:00
Mattt Thompson
9ad76f02fc Merge branch 'experimental-1.0RC2' of github.com:AFNetworking/AFNetworking into experimental-1.0RC2 2012-08-04 15:25:28 -04:00
Mattt Thompson
84eae9d31e Merge pull request #430 from tewha/patch-3
Small README formatting fix
2012-08-04 12:22:06 -07:00
Mattt Thompson
a144c8f0a7 Merge pull request #431 from tewha/patch-4
Fixes warning about using == on floats.
2012-08-04 12:17:58 -07:00
Mattt Thompson
173493c1f9 Merge pull request #436 from gcox/string-specifier-fix
Changed string format specifiers for NSUInteger values from %u to %lu
2012-08-04 12:09:41 -07:00
Mattt Thompson
3f32f8e660 Merge pull request #442 from tewha/patch-6
Fixed comment
2012-08-04 11:58:49 -07:00
Steven Fisher
1d82992f36 Fixed comment
Grammar problem in comment. Minor and easy to miss.
2012-08-03 19:56:48 -07:00
George Cox
2834ecc97d Changed string format specifiers for NSUInteger values from %u to %lu
Resolves two compiler warnings in AFHTTPRequestOperation.m and one in AFHTTPClient.m
2012-07-26 08:29:40 -04:00
George Cox
109037831a Fixed compiler error in AFHTTPRequestOperation; #417
Casting (void *) block to (__bridge id).  Required as of Xcode 4.4
2012-07-26 08:05:20 -04:00
Steven Fisher
eafbfec11c Fixes warning about using == on floats.
If the value changes from near to 2.0 to some other near 2.0, it's fine to recalculate.

Thus, use #pragma clang diagnostic to explicitly turn off the float-equal warning.
2012-07-24 12:36:25 -07:00
Steven Fisher
8e2da876d9 Small README fix
Markdown for code syntax does not work in a table cell. Now using <tt>.
2012-07-23 19:26:51 -07:00
Mattt Thompson
762a3effa8 Merge pull request #425 from tewha/implicit-sign-conversion
Fixed sign conversion warning.
2012-07-23 18:32:21 -07:00
Mattt Thompson
d509c54fe6 Merge pull request #427 from tewha/inc-imp-warning
Fixed incomplete implementation warning.
2012-07-23 18:26:36 -07:00
Mattt Thompson
1c7a037424 Merge pull request #428 from tewha/patch-2
README typo fix
2012-07-23 18:25:48 -07:00
Steven Fisher
ee9500ebff Just spotted a typo in the README. 2012-07-23 17:26:13 -07:00
Steven Fisher
5c4c94081b Fixed incomplete implementation warning.
sharedProfileImageRequestOperationQueue is declared in interface extension, but only implemented on Mac OS X. This causes an incomplete implementation warning. Added same #if around interface as surrounds impelmentation.

This only affects sample code.
2012-07-23 17:19:17 -07:00
Steven Fisher
1037a807f5 Fixed warning.
containsIndex takes a NSUInteger, not a NSInteger. When CLANG_WARN_IMPLICIT_SIGN_CONVERSION is set, this generates a warning.
2012-07-23 17:11:54 -07:00
Mattt Thompson
877333a08e Merge pull request #422 from tewha/master
Fix to pull 420
2012-07-23 17:03:28 -07:00
Mattt Thompson
b9641edc81 Updating documentation for -pause
Returning early for -pause if operation is already cancelled
2012-07-23 16:22:48 -07:00
Mattt Thompson
70787ce4cf [Issue #398] Adding state checks to AFURLConnectionOperation -pause to prevent likely memry issues when cancelling a non-existint connection 2012-07-23 16:20:11 -07:00
Steven Fisher
cc35e61ff6 Merge branch 'master' of git://github.com/AFNetworking/AFNetworking 2012-07-23 14:49:03 -07:00
Mattt Thompson
9236e41850 Fixing documentation in AFHTTPClient -deletePath:... to indicate new default of encoding parameters in query string 2012-07-23 12:15:11 -07:00
Mattt Thompson
69ff0781b2 Minor refactoring of changes to AFNetworkActivityIndicatorManager
Slightly reducing invisibility delay
2012-07-23 12:05:21 -07:00
Mattt Thompson
e6bbfab2ad Merge branch 'fixes/ActivityThreading' of git://github.com/talko/AFNetworking 2012-07-23 11:54:40 -07:00
Mattt Thompson
2fae4086de Merge pull request #413 from catnapgames/master
Fix compiler errors in README upload example
2012-07-23 11:44:18 -07:00
Steven Fisher
25186f8ebf Very minor security fix.
`informativeTextWithFormat` interprets its string as a format. `[error localizedDescription]` could contain string formatting specifiers.

Fixes to use @"%@", [error localizedDescription] instead.

Spotted via compiler warning.
2012-07-23 11:11:29 -07:00
Steven Fisher
69da97c5a8 Cast NSInteger to long.
Per Apple's Platform Dependencies in String Programming Guide, casting NSInteger to long before using %lu.

https://developer.apple.com/library/ios/#documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html#//apple_ref/doc/uid/TP40004265-SW5
2012-07-23 11:05:58 -07:00
Mattt Thompson
76c5b8e4de Merge pull request #420 from kgn/master
String formatting changes wanted by Xcode4.5 on Mountain Lion
2012-07-23 10:48:01 -07:00
David Keegan
b46284860d String formatting changes wanted by Xcode4.5 on Mountain Lion 2012-07-21 23:00:53 -07:00
Max Lansing
15155f6395 Merge remote-tracking branch 'upstream/master' into experimental-extreme-streaming 2012-07-19 22:26:36 -07:00
Max Lansing
c7f6fb09bf rejigger things to do callbacks and end-of-stream read properly 2012-07-19 22:23:38 -07:00
Peter Steinberger
fefd1a77ff don't use __weak for completionBlocks. (Issue #414)
We nil out the completionBlock manually in AFURLConnectionOperation. Using __weak here potentially doesn't call the set completion blocks.
Restores iOS4 compatibility. Also shortens inline ifs with a ternary conditional(?:).
2012-07-16 19:21:30 +02:00
tomas.a
c161a42033 Fix compiler warning in file upload progress example. Changed NSInteger to long long. 2012-07-12 17:48:12 +02:00
Mattt Thompson
5dc7be4c64 Merge pull request #412 from wlue/master
iOS 6 Warnings Fix
2012-07-11 07:31:54 -07:00
Wen-Hao Lue
415ece4dd4 Making the assign attribute on properties explicit to suppress warnings on iOS 6 SDK. 2012-07-11 01:05:01 -07:00
Eric Patey
a8210a93bb Fix threading issue with AFNetworkActivityIndicatorManager.
Changed updateNetworkActivityIndicatorVisibilityDelayed
to use the main run loop rather than the current run loop
for its suppression timer.
Also, avoided extra dispatch to the main queue when not needed.
2012-07-10 21:12:54 -04:00
Mattt Thompson
ae340b19e9 Removing whitespace leftover in dealloc from migration 2012-07-03 07:20:15 -07:00