Commit graph

470 commits

Author SHA1 Message Date
Mattt Thompson
8432cb7dfd Adding additional note about not ever really having to manually increment or decrement the activity count on AFNetworkActivityIndicatorManager 2012-06-11 07:57:33 -07:00
Mattt Thompson
5c26d435bf Removing @private variable declaration 2012-06-11 07:31:40 -07:00
Mattt Thompson
512a513ace [Issue 370] Remove unnecessary dispatch_retain for dispatchGroup in enqueueBatchOfHTTPRequestOperations... 2012-06-11 07:26:25 -07:00
Mattt Thompson
2071196450 Merge pull request #368 from AFNetworking/experimental-multipart-streaming
Multipart Upload Streaming
2012-06-11 07:19:00 -07:00
Mattt Thompson
9b515d4ebe Code reformatting and adding conditional callback queue dispatch to UIImage callback 2012-06-09 09:52:28 -04:00
Sergey Gavrilyuk
91d4614028 in case there is an image processing block, success block should be called on the same queue as without one. 2012-06-08 15:44:42 -04:00
Mattt Thompson
90db2543d7 Initial implementation of streaming multipart uploads by writing form body to temporary file 2012-06-05 08:56:27 -07:00
Mattt Thompson
aa5c3783ea Minor refactoring, code formatting, and documentation changes 2012-05-25 15:03:19 -07:00
Mattt Thompson
d17b2998d7 Merge branch 'url-redirect-block' of https://github.com/kcharwood/AFNetworking into kcharwood-url-redirect-block 2012-05-25 14:43:14 -07:00
Mattt Thompson
71610bbd3c Merge pull request #345 from tewha/patch-1
#import UIKit in AFURLConnectionOperation
2012-05-25 14:24:27 -07:00
Mattt Thompson
f02c501e93 [Issue #347] Removing deprecated cacheName parameter in AFImageRequestOperation 2012-05-25 14:15:12 -07:00
Steven Fisher
985d8cfd51 AFURLConnectionOperation.m should #import UIKit, instead of relying on the prefix including it. 2012-05-24 16:24:53 -07:00
Kevin Harwood
cd788cea8a Added URL Redirect Block 2012-05-24 14:45:01 -05:00
Mattt Thompson
09a8b1dbcf Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-05-24 09:43:17 -07:00
Mattt Thompson
170b3f0656 [Issue #342] Removing URL encoding normalization 2012-05-24 09:35:31 -07:00
Mattt Thompson
8657907f1a Merge pull request #336 from shanev/doc_fix
fixed AFHTTPClient documentation
2012-05-22 07:49:46 -07:00
Jon Parise
002cbe74af Avoid appending empty form data parts.
AFQueryStringComponentsFromKeyAndValue() always returns at least one
component (even if its `value` parameter is `nil`).  If a component
doesn't have any form data, there's no need for us to append an empty,
nameless part to the multipart body.

Additional improvements to consider (which are not mutually exclusive
with this change):

 - Don't run this loop at all when `parameters` is `nil`.
 - Change AFQueryStringComponentsFromKeyAndValue() to return an empty
   iterable when its `value` paramter is `nil`.
2012-05-14 17:07:07 -07:00
Jon Parise
ebdac4a01d Remove unused kAFMultipartFormLineDelimiter.
This constant appears to have been superseded by the introduction of
kAFMultipartFormCRLF later in this source file.  The latter is used
consistently in the multipart-building code, so this first one can go.
2012-05-14 16:53:44 -07:00
Shane Vitarana
c7a19a6e63 fixed AFHTTPClient documentation 2012-05-14 14:46:45 -07:00
Mattt Thompson
0ec7995128 Merge pull request #327 from flambert/missing-block-parameter-name
Add missing block parameter name preventing auto-complete to work
2012-05-07 09:11:09 -07:00
mattchen
31ccb23f69 Minor fix for tornado upload support 2012-05-06 17:12:20 +08:00
Francois Lambert
8ce55df371 Add missing block parameter name preventing auto-complete to work
When function name is auto-completed and the imageProcessingBlock stub is created, it was missing the UIImage* parameter name.
2012-05-03 18:50:32 -04:00
Mattt Thompson
7a57210e6d [Issue #295] Fixing documentation for UIImageView+AFNetworking to use correct enum value for NSURLRequest cache policy 2012-05-03 07:47:00 -07:00
Mattt Thompson
8f7ad20117 Merge pull request #325 from tewha/patch-1
Update AFNetworking/AFHTTPRequestOperation.m
2012-05-03 07:40:12 -07:00
Steven Fisher
00a6d249e4 Update header comment to match file name 2012-05-02 11:08:01 -07:00
Steven Fisher
021fe2b463 Update AFNetworking/AFHTTPRequestOperation.m 2012-05-02 10:13:03 -07:00
Mattt Thompson
2f79428e34 [Issue #323] Close existing outputStream in setOutputStream: 2012-05-01 08:04:29 -07:00
Mattt Thompson
3ee1fefeac Minor formatting 2012-04-30 10:49:00 -07:00
Zachary Waldowski
25620fe839 Restore iOS 4.0 compatibility.
Signed-off-by: Zachary Waldowski <zwaldowski@gmail.com>
2012-04-28 18:00:28 -04:00
Tom Wanielista
02c849bdc8 Fix an issue where the skipped character set points to bad memory. 2012-04-27 11:45:47 -07:00
dismory
b76b28f4b3 Fix the duplicated AFJSONDecode() calling that cause message sending to deallocated NSError object 2012-04-25 16:02:29 +08:00
Mattt Thompson
ce23a0757b [Issue #274] Fixing crash when creating network reachability when baseURL is nil 2012-04-24 22:22:32 -07:00
Mattt Thompson
346799dc8b Adding documentation for pause/resume 2012-04-24 21:28:06 -07:00
Mattt Thompson
4c8634dfce Removing AFDownloadRequestOperation 2012-04-24 20:43:46 -07:00
Mattt Thompson
7e16e13a3a Merge branch 'experimental-1.0RC1' into experimental-pause-resume
Conflicts:
	AFNetworking/AFURLConnectionOperation.h
	AFNetworking/AFURLConnectionOperation.m
2012-04-24 20:42:59 -07:00
Mattt Thompson
7697140bf9 Merge branch 'master' into experimental-1.0RC1
Conflicts:
	AFNetworking/AFHTTPRequestOperation.h
	AFNetworking/AFHTTPRequestOperation.m
2012-04-24 20:36:43 -07:00
Mattt Thompson
ac67d7e918 Merge branch 'steipete-pause-resume' into experimental-pause-resume 2012-04-24 20:28:08 -07:00
Mattt Thompson
701a60a10f Merge branch 'master' into experimental-pause-resume
Conflicts:
	AFNetworking/AFHTTPRequestOperation.h
	AFNetworking/AFHTTPRequestOperation.m
2012-04-24 20:27:37 -07:00
Mattt Thompson
77837c48de Run batch callbacks on success dispatch queue, falling back on main 2012-04-24 20:24:21 -07:00
Mattt Thompson
bbacf3d7c6 Removing unnecessary initialization of completionBlock in init 2012-04-24 20:06:47 -07:00
Mattt Thompson
8a93284ca4 Ah, the wonderful feeling of deleting significant chunks of code 2012-04-23 21:14:27 -07:00
Mattt Thompson
3124db42cd Stashing first attempt to simplify dispatching 2012-04-23 20:58:14 -07:00
Mattt Thompson
4a354fda24 Merge pull request #294 from kirsplatrick/callbackQueue-fix
Fixed crash in special case for custom callback queues
2012-04-23 20:22:19 -07:00
Charles T. Ahn
c0bdc5db95 Try-catch in Objective-C should not be used to recover from exceptions
http://developer.apple.com/library/ios/#documentation/cocoa/conceptual/Exceptions/Articles/ExceptionsAndCocoaFrameworks.html#//apple_ref/doc/uid/TP40009045-SW1

Relevant Quote:
  "The Cocoa frameworks are generally not exception-safe. The general
  pattern is that exceptions are reserved for programmer error only, and
  the program catching such an exception should quit soon afterwards."

More discussion here:
http://stackoverflow.com/questions/324284/how-to-throw-an-exception-in-objective-c-cocoa

Given all this, prefer a crash on the background thread.
2012-04-19 13:17:56 -07:00
Mattt Thompson
9adb586a82 [Issue #308] Fixing crash caused by attempting to cache invalid or nil image 2012-04-19 10:31:45 -05:00
Mattt Thompson
94d6a6c236 Merge pull request #298 from bONchON/master
Fixing race condition in UIImageView+AFNetworking that caused images to not load on occasion.
2012-04-14 21:49:42 -07:00
Mattt Thompson
bf6e45eac9 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-04-14 21:42:25 -07:00
Mattt Thompson
da7d1c8c11 [Issue #296] Dispatching image processing asynchronously to background queue 2012-04-14 21:42:18 -07:00
Patrick Hernandez
3263f06edb Fixed a leak of AFHTTPRequestOperation in setCompletionBlock:
- Added a block object to reference self in the completion block
- Added a pointer to the onceToken to be used in the completion block
2012-04-14 15:16:14 -05:00
John Wu
ec3b922288 since there is no guarantee that
cancelling a request => success/fail block will not be called,
you shouldn't nil out a request unless it corresponds to the correct URL.
Essentially, this fixes the problem where images are sometimes not loaded.
2012-04-13 11:04:13 -07:00