Commit graph

694 commits

Author SHA1 Message Date
Mattt Thompson
9adb586a82 [Issue #308] Fixing crash caused by attempting to cache invalid or nil image 2012-04-19 10:31:45 -05:00
Mattt Thompson
94d6a6c236 Merge pull request #298 from bONchON/master
Fixing race condition in UIImageView+AFNetworking that caused images to not load on occasion.
2012-04-14 21:49:42 -07:00
Mattt Thompson
bf6e45eac9 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-04-14 21:42:25 -07:00
Mattt Thompson
da7d1c8c11 [Issue #296] Dispatching image processing asynchronously to background queue 2012-04-14 21:42:18 -07:00
Mattt Thompson
c4b5772431 Merge pull request #302 from kirsplatrick/AFHTTPRequestOperation-leak-fix
Fixed a leak of AFHTTPRequestOperation in setCompletionBlock:
2012-04-14 19:07:12 -07:00
Patrick Hernandez
3263f06edb Fixed a leak of AFHTTPRequestOperation in setCompletionBlock:
- Added a block object to reference self in the completion block
- Added a pointer to the onceToken to be used in the completion block
2012-04-14 15:16:14 -05:00
John Wu
ec3b922288 since there is no guarantee that
cancelling a request => success/fail block will not be called,
you shouldn't nil out a request unless it corresponds to the correct URL.
Essentially, this fixes the problem where images are sometimes not loaded.
2012-04-13 11:04:13 -07:00
Mattt Thompson
9a07a953a7 Fixing pragma mark label 2012-04-13 08:37:04 -07:00
Mattt Thompson
673e70525a Merge pull request #291 from steipete/fix-cache-policy
The cache policy set here was from the WRONG enum.
2012-04-12 20:04:00 -07:00
Mattt Thompson
23763688de Merge pull request #288 from kirsplatrick/experimental-dispatchgroup
Update to support batch completion block firing after all dependent completion blocks.
2012-04-12 19:31:52 -07:00
Patrick Hernandez
1e78a5b2f9 Fixed crash in special case for custom callback queues
- Added a line for setting _successCallbackQueue to NULL when releasing the call back queue in the setter
- Added a line for setting _failureCallbackQueue to NULL when releasing the call back queue in the setter
2012-04-11 18:37:53 -05:00
Peter Steinberger
dec3c9a03b The cache policy set here was from the WRONG enum.
So NSURLCacheStorgeNotAllowed has the value 2, which maps to NSURLRequestReturnCacheDataElseLoad. I'm not sure why this is here in the first place, but the correct enum is of the type NSURLRequestCachePolicy.
2012-04-10 19:32:30 -07:00
Mattt Thompson
ddfb00cc44 Merge branch 'experimental-pause-resume' of https://github.com/steipete/AFNetworking into steipete-pause-resume 2012-04-09 21:40:49 -07:00
Peter Steinberger
47f6793c3f Restore download resuming.
The default destination will be the documents folder, unless set otherwise. We also look into the response metadata for the actual filename (unless set otherwise)
2012-04-09 17:47:02 -07:00
Peter Steinberger
61eda7c4e0 adds function to responseFilePath (streaming into a file, if set)
adds total/offsetContentLength. We really need those in case we pause/resume.
2012-04-09 17:45:41 -07:00
Peter Steinberger
24564772df create and set temporary path 2012-04-09 13:58:36 -07:00
Peter Steinberger
2413d95c3f we don't need to declare ivars anymore. 2012-04-09 13:58:36 -07:00
Patrick Hernandez
7c603a9fad Merge branch 'master' into experimental-dispatchgroup 2012-04-09 00:59:12 -05:00
Patrick Hernandez
8b94ef8e44 Optimized how enqueueing operations works
- Removed the NSBlockOperation as it was not longer needed for completion block to be fired appropriately
- Added a safety call to setCompletionBlock in AFHTTPRequestOperation to ensure that dispatch_group_leave would be called
2012-04-09 00:19:28 -05:00
Patrick Hernandez
e47fc50903 removing the .gitignore 2012-04-08 23:04:09 -05:00
Patrick Hernandez
57da89896c Update to support batch completion block firing after all dependent completion blocks.
- Added dispatch group property to AFHTTPRequestOperation
- Modified all request objects to call dispatch_group_async in completion blocks
- Added a dispatch semaphore for thread safety of the dispatch group property
- Added dispatch_group_enter and dispatch_group_leave calls to ensure requests are always in the group until the completion block finishes.
- Added an override for setCompletionBlock to call dispatch_group_leave so that subclasses do not need the call in each completion block.
- Modified enqueueBatchOfHTTPRequestOperations to now dispatch_group_notify in the NSBlockOperation completion block
2012-04-08 22:31:35 -05:00
Patrick Hernandez
3c9f09b959 commiting the .gitignore file 2012-04-08 18:18:13 -05:00
Mattt Thompson
da1acf5a56 Merge branch 'master' into experimental-pause-resume
Conflicts:
	AFNetworking/AFHTTPRequestOperation.h
	AFNetworking/AFURLConnectionOperation.h
2012-04-08 15:28:58 -07:00
Mattt Thompson
407374746c Removing unnecessary ivar declaration in headers 2012-04-08 15:25:20 -07:00
Mattt Thompson
2f94a89f80 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-04-08 14:26:59 -07:00
Mattt Thompson
14aea9ee58 [Issue #268] Reverting to cacheing UIImages rather than NSPurgeableData-wrapped image data 2012-04-08 14:26:52 -07:00
Mattt Thompson
f2ce416ca2 Adding AFDownloadRRequestOperation to project files 2012-04-08 14:15:18 -07:00
Mattt Thompson
e4c84db10b Removing stray newline 2012-04-08 12:42:44 -07:00
Mattt Thompson
60a391ac2a Merge branch 'experimental-background-task-blocks' into experimental-1.0RC1
Conflicts:
	AFNetworking/AFHTTPClient.m
2012-04-08 12:39:06 -07:00
Mattt Thompson
9e73238a7b Merge branch 'master' into experimental-1.0RC1 2012-04-08 12:35:47 -07:00
Mattt Thompson
c5c29e31a8 Merge pull request #283 from steipete/remove-unneeded-kvo-calls
Remove obsolete manual KVO will/did change calls.
2012-04-08 12:10:31 -07:00
Mattt Thompson
6923e31db5 Minor code re-formatting and documentation changes 2012-04-08 12:02:19 -07:00
Mattt Thompson
37275860d7 Merge branch 'lock-improvements' of https://github.com/steipete/AFNetworking into steipete-lock-improvements 2012-04-08 11:51:13 -07:00
Mattt Thompson
cc204ec6de Merge pull request #281 from steipete/example-fixes
Small fix for the tweet example.
2012-04-08 11:50:32 -07:00
Peter Steinberger
ed4c558755 remote obsolete KVO change calls.
See http://petersteinberger.com/blog/2012/dont-call-willchangevalueforkey/.

I didn't remove the call in the AFNetworkActivityIndicatorManager, since I already removed this in my other pull request.
2012-04-06 01:46:58 -07:00
Peter Steinberger
e2751e6ffc protect decrementActivityCount against integer underflow. 2012-04-05 17:49:08 -07:00
Peter Steinberger
069615a20d Use lightweight locking for activityCount
Also exposes isNetworkActivityIndicatorVisible which now is KVO observable.
2012-04-05 17:29:18 -07:00
Peter Steinberger
88920034e2 fixes a blocked reload button once we hit an error. Also shows an alert now. 2012-04-04 17:17:06 -07:00
Mattt Thompson
0470f4b29f [Issue #278] Adding thread safety to incrementing / decrementing and display of network activity indicator 2012-04-04 16:31:52 -07:00
Mattt Thompson
a0967f5d4f Removing @gowalla.com e-mail address 2012-03-31 13:02:06 -07:00
Mattt Thompson
0e6b58ba60 [Issue #266] Re-adding conditional in multipartFormRequestWithMethod:... that does not doubly-encode NSData parameter values 2012-03-28 10:08:49 -07:00
Mattt Thompson
9e5ff6dcf5 [Issue #266] Fixing GET and POST parameter encoding 2012-03-28 10:05:00 -07:00
Mattt Thompson
4cf0199712 Reverting AFDownloadRequestOperation to be a subclass of AFHTTPRequestOperation 2012-03-27 12:11:46 -07:00
Mattt Thompson
2a1d81a792 Cleaning up experimental bits
Re-creating AFDownloadRequestOperation, now with an API closer to NSURLDownload
2012-03-27 12:05:00 -07:00
Mattt Thompson
ca697ce300 Settling on a relatively stable implementation of pause/resume 2012-03-27 11:01:20 -07:00
Mattt Thompson
1e408ba2af Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-03-27 09:09:11 -07:00
Mattt Thompson
8606378b69 [Issue #267] Fixing compiler warning on undeclared AFQueryStringComponentFromKeyAndValueWithEncoding 2012-03-27 09:09:03 -07:00
Mattt Thompson
e37a6af943 Merge branch 'experimental-1.0RC1' into experimental-resumeable-streaming-downloads
Conflicts:
	AFNetworking/AFHTTPRequestOperation.h
	AFNetworking/AFHTTPRequestOperation.m
2012-03-26 11:31:11 -07:00
Mattt Thompson
c40983e56f Adding -temporaryPath property to AFHTTPRequestOperation 2012-03-26 11:29:31 -07:00
Mattt Thompson
331d7bcbf2 Moving resumeable streaming download functionality to AFHTTPRequestOperation 2012-03-25 12:23:40 -07:00