evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1094 commits 1 branch 0 tags 2.4 MiB
Commit graph

258 commits

Author SHA1 Message Date
Oliver Jones
3486a008a1 Fixing warnings: implicit conversion changes signedness: 'NSInteger' (aka 'long') to 'unsigned long' [-Werror,-Wsign-conversion] 2012-11-29 17:53:30 +11:00
Nick Forge
3175869333 Fixed retain cycles in AFImageRequestOperation.m and AFHTTPClient.m caused by strong references within blocks 
These retain cycles started showing up as compiler warnings after upgrading to Xcode 4.6DP
 2012-11-21 15:48:18 +11:00
Cédric Luthi
f106d19536 Use NSLocalizedStringFromTable with AFNetworking.strings table for localized strings 2012-11-14 17:44:11 +01:00
Tomohisa Takaoka
c92f306c6d Issue: Timeout when buffer ends during ending boundry 2012-11-09 14:23:51 -08:00
Mattt Thompson
247863cfc2 [Issue #633] Manually casting scalar types in initWithCoder for AFURLConnectionOperation and AFHTTPClient 2012-11-09 07:31:53 -08:00
Mattt Thompson
ff8e70a49c Using addOperations:waitUntilFinished: instead of adding each operation individually in -enqueueBatchOfHTTPRequestOperations:... to fix an edge case bug where only one of the operations in a batch will run. 2012-11-06 12:03:19 -08:00
Mattt Thompson
24dfebb424 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-11-06 09:22:04 -08:00
Mattt Thompson
5ec794dc4d Indenting macro conditionals 2012-11-06 09:21:41 -08:00
Cédric Luthi
db10b25bb2 Derive keys string representations using the description method as specified in AFQueryStringFromParametersWithEncoding documentation 2012-11-06 15:16:48 +01:00
Mattt Thompson
5b32b45469 [Issue #619] Sorting dictionary keys with caseInsensitiveCompare to ensure deterministic ordering of query string parameters, which may otherwise cause ambiguous representations of nested parameters 2012-11-05 12:03:23 -08:00
Stan Chang Khin Boon
2fde59c3fd [Issue #591] Attempts to fix crash caused by incorrect calculation of range when reading data into buffer. 
When the current buffer isn't large enough to store the data,
AFNetworking attempts to fill the current buffer with as much data as
it can holds and leaves the remaining data to the next buffer.

There is a bug when calculating the range to read from data in the next
buffer. The `_phaseReadOffset` is set correctly but the `[data length]`
is not adjusting correctly to the offset. This causes `getBytes:range:`
to complains that it attempts to get bytes that are out of range.

An attempted fix is done here by adjusting the range (Also adjust to
check against `_phaseReadOffset` instead of `range.length`.

As I am modifying some critical section, a detail review might be
required.

I am sending this pull request so as to facilitiate the review process,
but if you are already in review of the issue and the solution, you can
ignore my pull and close it. Thanks!

Detail explanation of how the solution come about can be found here:
https://github.com/AFNetworking/AFNetworking/issues/591#issuecomment-993
0763
 2012-11-01 02:42:14 +08:00
Mattt Thompson
e2f2ab45aa [Issue #599] Refactoring AFHTTPClient to remove unnecessary JSON / plist serialization functions, logging any error that may arise. 2012-10-31 09:55:18 -07:00
Mattt Thompson
652ad787e7 Minor reformatting of weak/strong self pattern for network reachability callbacks 2012-10-31 07:42:19 -07:00
Dan Weeks
e549ee33a9 use the weakself/strongself pattern to fix AFHTTPClient not being released 
see AFNetworking issue #581
 2012-10-30 11:58:54 -07:00
Diego Torres
7945e801dc Set the dot (.) to be unescaped (fixes #597) 2012-10-24 15:55:40 -02:00
Andrew Sardone
62e2deddb1 Remove executable permission on AFHTTPClient source files 
For some reason the file mode was changed to add an executable
permission in commit d92462ef8c. This
change is basically inessential housekeeping.
 2012-10-18 10:05:24 -04:00
Mattt Thompson
1637ee2e67 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-10-16 08:17:50 -07:00
Sylver Bruneau
d61c2ea526 [Issue #579] Fixing last file component in multipart form part creation 2012-10-16 08:17:42 -07:00
Dan Weeks
d635972ee5 avoid warning (error with -Werror) on implicit 64 to 32 conversion 2012-10-15 14:12:16 -07:00
Mattt Thompson
73f994472f Using consistent urlRequest parameter name in AFHTTPClient 2012-10-14 10:22:40 -07:00
Mattt Thompson
6f999cdeff NSCParameterAssert -> NSParameterAssert 2012-10-14 10:06:50 -07:00
Mattt Thompson
ddf43e1122 Revert "Using NS_ENUM in place of typedef enum" 
This reverts commit ae1d419cd4.
 2012-10-09 17:38:08 -07:00
Mattt Thompson
ae1d419cd4 Using NS_ENUM in place of typedef enum 2012-10-09 09:46:30 -07:00
Mattt Thompson
e8b3e27043 Replacing existing property ownership values of retain with strong 2012-10-09 09:26:50 -07:00
Mattt Thompson
bad206b41f [Issue #465] Instead of enforcing non-nil parameter, allow it to signify not appending a path to the base URL when matching 2012-10-09 09:14:26 -07:00
Mattt Thompson
d3ae3d128f [Issue #465] Enforcing non-nil path constraint, and making it so that path is relative to the path of the client baseURL 
[Issue #465] Providing additional explanation about how to manage the lifecycle of enqueued operations
 2012-10-09 09:10:23 -07:00
Mattt Thompson
b10f66062c Changing multipartFormRequestWithMethod:... to black-list GET and HEAD rather than whitelist particular methods. 
Enforcing non-nil, non-GET / HEAD method parameter requirement
 2012-10-09 08:59:42 -07:00
Mattt Thompson
30aeb09d2f Adding requirement that method not be nil in requestWithMethod:path:parameters 
Defaulting path to blank string if nil
 2012-10-09 08:58:13 -07:00
Mattt Thompson
8d2310098c Removing unnecessary import statement for SystemConfiguration framework if _SYSTEMCONFIGURATION_H is already defined 2012-10-05 10:27:38 -07:00
Mattt Thompson
cbab8fd6b0 Using better negation for OS_OBJECT_USE_OBJC macros 2012-10-05 10:24:28 -07:00
Mattt Thompson
278aa2edfc Fixing OS_OBJECT_USE_OBJC macro check 2012-10-05 10:21:39 -07:00
Mattt Thompson
a2fc510f72 Enforcing 'this parameter must not be nil' by using NSCParameterAssert() 2012-10-05 10:09:13 -07:00
Mattt Thompson
c091bb5ebe [Issue #557] Replacing AF_DISPATCH_RETAIN_RELEASE macro with OS_OBJECT_USE_OBJC (thanks, @nakiwo) 2012-10-05 09:27:49 -07:00
Mattt Thompson
a244a53b66 If a query string pair has a nil or NSNull value, just use the field as the string value 2012-10-05 09:20:05 -07:00
Mattt Thompson
d97356c35c Use isEqual: to determine if value is NSNull 2012-10-05 09:12:00 -07:00
Daniel Rinser
d8f074dcfa [Issue #559] Fixed body for NSNull parameter values in multipart/form-data requests 
Parts for parameters with a value of NSNull now have an empty body rather than "<null>" (which was produced by -[NSNull description]).
 2012-10-05 15:56:48 +02:00
Aron Cedercrantz
48d0bf82d8 Fix type discrepancy for upload stream delay. 
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
 2012-10-04 23:03:54 +02:00
Mattt Thompson
43e13be0ba Merge branch 'master' of github.com:AFNetworking/AFNetworking 
Conflicts:
	AFNetworking/AFHTTPClient.m
 2012-10-03 08:50:07 -07:00
Mattt Thompson
3f3a79221a [Issue #555] Leaving square brackets unescaped in query string parameters 2012-10-03 08:49:39 -07:00
Mattt Thompson
f9c0576f89 [Issue #554] Re-adding AFMultipartFormData -appendPartWithHeaders:body: 2012-10-03 08:37:25 -07:00
Mattt Thompson
b118e93986 Merge pull request #547 from jbrennan/bugfix/httpclient-nil-url-exception 
-[AFHTTPClient initWithBaseURL:] will now raise an exception with a nil URL parameter.
 2012-10-02 09:47:47 -07:00
Mattt Thompson
9cdea00b07 [Issue #548] Reverting breaking changes from b317c7d5d9 2012-10-02 09:41:57 -07:00
Jason Brennan
284f57d39f -initWithBaseURL: will now raise an exception with a nil URL parameter. This enforces what the code comments say. 
Without this, Reachability might cause the application to crash on iOS 6 if the baseURL is nil.
 2012-10-02 10:53:07 -04:00
Mattt Thompson
b317c7d5d9 Fixing warnings triggered by -Weverything flag 
Explicitly covering all enum values in switch statements

Removing unused, unsynthesized properties

Adding missing synthesizers for properties

Fixing misuse of compiler macro
 2012-10-01 10:45:43 -07:00
Mattt Thompson
3ca7762bd2 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-09-30 17:38:34 -07:00
Mattt Thompson
1c1b204513 [Issue #546][Issue #513] Adding AFMultipartFormData -throttleBandwidthWithPacketSize:delay: 2012-09-30 17:38:07 -07:00
Blake Watters
5704f0ae8d Import UIKit to avoid build errors from UIDevice references in "User-Agent" default header. closes AFNetworking/AFNetworking#542 2012-09-26 20:56:33 -04:00
Mattt Thompson
70b7e0522c Changing NSError ** parameter to NSError * __autoreleasing * 
Minor reformatting of AFHTTPClient method signatures
 2012-09-26 11:39:28 -07:00
Mattt Thompson
bec09ed3a3 Removing #imports for CoreServices 2012-09-25 12:20:08 -07:00
Mattt Thompson
d67e8a6bd6 Additional refactoring and reformatting 
Fixing memory management issue in AFContentTypeForPathExtension
 2012-09-25 11:06:03 -07:00