Commit graph

156 commits

Author SHA1 Message Date
Mattt Thompson
d7852c19e1 Reformatting method signatures in multipart form builder implementation 2012-06-12 08:20:08 -07:00
Mattt Thompson
6b9187b6c2 Close the stream and return the original request if no data has been written for multipart request form data 2012-06-12 08:01:50 -07:00
Mattt Thompson
5c26d435bf Removing @private variable declaration 2012-06-11 07:31:40 -07:00
Mattt Thompson
512a513ace [Issue 370] Remove unnecessary dispatch_retain for dispatchGroup in enqueueBatchOfHTTPRequestOperations... 2012-06-11 07:26:25 -07:00
Mattt Thompson
90db2543d7 Initial implementation of streaming multipart uploads by writing form body to temporary file 2012-06-05 08:56:27 -07:00
Mattt Thompson
170b3f0656 [Issue #342] Removing URL encoding normalization 2012-05-24 09:35:31 -07:00
Jon Parise
002cbe74af Avoid appending empty form data parts.
AFQueryStringComponentsFromKeyAndValue() always returns at least one
component (even if its `value` parameter is `nil`).  If a component
doesn't have any form data, there's no need for us to append an empty,
nameless part to the multipart body.

Additional improvements to consider (which are not mutually exclusive
with this change):

 - Don't run this loop at all when `parameters` is `nil`.
 - Change AFQueryStringComponentsFromKeyAndValue() to return an empty
   iterable when its `value` paramter is `nil`.
2012-05-14 17:07:07 -07:00
Jon Parise
ebdac4a01d Remove unused kAFMultipartFormLineDelimiter.
This constant appears to have been superseded by the introduction of
kAFMultipartFormCRLF later in this source file.  The latter is used
consistently in the multipart-building code, so this first one can go.
2012-05-14 16:53:44 -07:00
mattchen
31ccb23f69 Minor fix for tornado upload support 2012-05-06 17:12:20 +08:00
Mattt Thompson
ce23a0757b [Issue #274] Fixing crash when creating network reachability when baseURL is nil 2012-04-24 22:22:32 -07:00
Mattt Thompson
7697140bf9 Merge branch 'master' into experimental-1.0RC1
Conflicts:
	AFNetworking/AFHTTPRequestOperation.h
	AFNetworking/AFHTTPRequestOperation.m
2012-04-24 20:36:43 -07:00
Mattt Thompson
77837c48de Run batch callbacks on success dispatch queue, falling back on main 2012-04-24 20:24:21 -07:00
Mattt Thompson
8a93284ca4 Ah, the wonderful feeling of deleting significant chunks of code 2012-04-23 21:14:27 -07:00
Mattt Thompson
3124db42cd Stashing first attempt to simplify dispatching 2012-04-23 20:58:14 -07:00
Mattt Thompson
673e70525a Merge pull request #291 from steipete/fix-cache-policy
The cache policy set here was from the WRONG enum.
2012-04-12 20:04:00 -07:00
Peter Steinberger
dec3c9a03b The cache policy set here was from the WRONG enum.
So NSURLCacheStorgeNotAllowed has the value 2, which maps to NSURLRequestReturnCacheDataElseLoad. I'm not sure why this is here in the first place, but the correct enum is of the type NSURLRequestCachePolicy.
2012-04-10 19:32:30 -07:00
Patrick Hernandez
8b94ef8e44 Optimized how enqueueing operations works
- Removed the NSBlockOperation as it was not longer needed for completion block to be fired appropriately
- Added a safety call to setCompletionBlock in AFHTTPRequestOperation to ensure that dispatch_group_leave would be called
2012-04-09 00:19:28 -05:00
Patrick Hernandez
57da89896c Update to support batch completion block firing after all dependent completion blocks.
- Added dispatch group property to AFHTTPRequestOperation
- Modified all request objects to call dispatch_group_async in completion blocks
- Added a dispatch semaphore for thread safety of the dispatch group property
- Added dispatch_group_enter and dispatch_group_leave calls to ensure requests are always in the group until the completion block finishes.
- Added an override for setCompletionBlock to call dispatch_group_leave so that subclasses do not need the call in each completion block.
- Modified enqueueBatchOfHTTPRequestOperations to now dispatch_group_notify in the NSBlockOperation completion block
2012-04-08 22:31:35 -05:00
Mattt Thompson
60a391ac2a Merge branch 'experimental-background-task-blocks' into experimental-1.0RC1
Conflicts:
	AFNetworking/AFHTTPClient.m
2012-04-08 12:39:06 -07:00
Mattt Thompson
9e73238a7b Merge branch 'master' into experimental-1.0RC1 2012-04-08 12:35:47 -07:00
Mattt Thompson
0e6b58ba60 [Issue #266] Re-adding conditional in multipartFormRequestWithMethod:... that does not doubly-encode NSData parameter values 2012-03-28 10:08:49 -07:00
Mattt Thompson
9e5ff6dcf5 [Issue #266] Fixing GET and POST parameter encoding 2012-03-28 10:05:00 -07:00
Mattt Thompson
8606378b69 [Issue #267] Fixing compiler warning on undeclared AFQueryStringComponentFromKeyAndValueWithEncoding 2012-03-27 09:09:03 -07:00
Mattt Thompson
ca87ea1a25 Refactoring network reachability functions
Using inet_pton instead of regexp to detect whether a URL host is an IP address
2012-03-20 16:43:19 -07:00
Mattt Thompson
700ad2a9eb Merge branch 'master' into experimental-expanded-network-reachability 2012-03-20 15:54:37 -07:00
Mattt Thompson
2868b069cd Adding missing extern specifier for AFQueryStringComponentFromKeyAndValueWithEncoding(...) 2012-03-20 11:32:44 -07:00
Kevin Harwood
50c136f5d4 Refactored the Reachability status logic 2012-03-20 11:48:54 -05:00
Mattt Thompson
71ebcfff8b Minor refactoring to query string parameter functions in AFHTTPClient 2012-03-19 14:36:22 -04:00
Mattt Thompson
acd6e49294 [Issue #243] Fixing AFQueryStringFromParametersWithEncoding to encode nested array values correctly 2012-03-19 12:44:06 -04:00
Kevin Harwood
428c13e1e0 Refactored starting up reachability 2012-03-14 08:23:18 -05:00
Kevin Harwood
d96f8f3fde Updated Reachability to handle an IP Address or a Host name
Note this does not fix the issue with the status not being correctly
reported for a 3G connection.
2012-03-13 09:12:58 -05:00
Mattt Thompson
4bfa2f4de0 Circumventing need to set initial network reachability status block to nil by wrapping callback in -startMonitoringNetworkReachability 2012-03-11 10:53:06 -07:00
Mattt Thompson
14227aadc7 Reverting network reachability status from bitmask to enum 2012-03-11 10:36:14 -07:00
Mattt Thompson
fa01557f4a Add setReachabilityStatusChangeBlock to AFHTTPClient initialization 2012-03-11 10:31:11 -07:00
Josh Chung
320f1ae114 added '&' between parameters in query string 2012-03-10 17:03:29 +09:00
Mattt Thompson
71d6af9e5c Renaming AFNetworkReachabilityStatus and changing to bitmask
Fixing AFReachabilityCallback to give correct WiFi reachability value

Minor formatting and refactoring
2012-03-09 15:48:59 -08:00
Mattt Thompson
be19b45c13 Merge branch 'AFHTTPClient-Reachability-Experiment' of https://github.com/kcharwood/AFNetworking into kcharwood-AFHTTPClient-Reachability-Experiment 2012-03-09 14:44:05 -08:00
Mattt Thompson
3c33b744f7 Minor code formatting 2012-03-09 14:08:24 -08:00
Mathieu Hausherr
bc7d320ee9 Multi level query parameters support for Multipart and Formencoded requests
Generate keys like 'key1[key2][][key3]'

Solve this problem
http://stackoverflow.com/questions/9605269/afhttpclient-invalid-tokens-in-dictionary-when-using-afformurlparameterencoding
2012-03-07 22:50:25 +01:00
Kevin Harwood
346c56b8f4 Changed AFReachabilityStatus naming scheme to be more clear 2012-03-05 16:21:45 -06:00
Kevin Harwood
5b49cbbc86 Added additional Reachability information to the AFHTTPClient
As discussed by @mattt in #197, this pull request takes a stab at
exposing the Reachability state via an enum property, similar to
Reachability itself.
2012-03-05 16:01:12 -06:00
Mattt Thompson
d2b02c3f17 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-03-01 09:09:21 -08:00
Mattt Thompson
cac44aeb34 Skip non-AFHTTPRequestOperations in AFHTTPClient -cancelAllHTTPOperationsWithMethod 2012-03-01 09:09:17 -08:00
Mattt Thompson
4f31148101 Adding AFHTTPClient -patchPath: convenience method 2012-02-28 18:18:08 -08:00
Patrick Hernandez
cc2115e469 Made progressBlock call back to the main queue by default. 2012-02-28 17:12:10 -06:00
Patrick Hernandez
0fc6f980b9 A fix for batch enqueue completion block returning on background thread 2012-02-28 16:39:25 -06:00
Mattt Thompson
ad27bd0397 [Issue #209] Adding conditional in AFURLEncodedStringFromStringWithEncoding to correctly handle cases where '%' is passed in literally, and not interpreted as an escape sequence, which would have previously caused the subsequent string to be nil. 2012-02-20 19:31:55 -08:00
Mattt Thompson
4266dc60d1 Adding notifications for network reachability changes to AFHTTPClient 2012-02-01 11:27:57 -08:00
C. Bess
fe56222f5c Updated reachability flags. 2012-01-28 14:13:52 -06:00
C. Bess
3e4725bb3e Improved reachability check, detects severed internet connections. 2012-01-28 13:59:40 -06:00