evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1191 commits 1 branch 0 tags 2.4 MiB
Commit graph

1191 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mattt Thompson
6f64dc2b65 Merge pull request #617 from tewha/master 
Document change in CHANGES
 2012-11-01 08:46:54 -07:00
Mattt Thompson
aab0ceec08 Merge pull request #618 from lxcid/master 
[Issue #591] Attempts to fix crash caused by incorrect calculation of range when reading data into buffer.
 2012-11-01 08:36:03 -07:00
Stan Chang Khin Boon
2fde59c3fd [Issue #591] Attempts to fix crash caused by incorrect calculation of range when reading data into buffer. 
When the current buffer isn't large enough to store the data,
AFNetworking attempts to fill the current buffer with as much data as
it can holds and leaves the remaining data to the next buffer.

There is a bug when calculating the range to read from data in the next
buffer. The `_phaseReadOffset` is set correctly but the `[data length]`
is not adjusting correctly to the offset. This causes `getBytes:range:`
to complains that it attempts to get bytes that are out of range.

An attempted fix is done here by adjusting the range (Also adjust to
check against `_phaseReadOffset` instead of `range.length`.

As I am modifying some critical section, a detail review might be
required.

I am sending this pull request so as to facilitiate the review process,
but if you are already in review of the issue and the solution, you can
ignore my pull and close it. Thanks!

Detail explanation of how the solution come about can be found here:
https://github.com/AFNetworking/AFNetworking/issues/591#issuecomment-993
0763
 2012-11-01 02:42:14 +08:00
Steven Fisher
9c34a68fba Document change for next version. 2012-10-31 10:21:43 -07:00
Mattt Thompson
e2f2ab45aa [Issue #599] Refactoring AFHTTPClient to remove unnecessary JSON / plist serialization functions, logging any error that may arise. 2012-10-31 09:55:18 -07:00
Mattt Thompson
175c3fa451 [Issue #565] Checking for kCFStringEncodingInvalidId from CFStringConvertIANACharSetNameToEncoding() before getting NSStringEncoding with CFStringConvertEncodingToNSStringEncoding, which may otherwise lead to unexpected behavior 2012-10-31 08:37:47 -07:00
Mattt Thompson
d31e23af29 [Issue #603] Removing duplicated runloop scheduling of outputStream 2012-10-31 08:27:10 -07:00
Mattt Thompson
81f33ae971 [Issue #592][Issue #600] Changes the logic of UIImageView -setImageWithURLRequest:placeholderImage:success:failure: such that if the success block is specified, the default behavior of self.image = image is not executed. This allows for full customization over any post-processing on the image, or the animation to be used when setting the image. 2012-10-31 08:20:58 -07:00
Mattt Thompson
ebc9f7d50e Removing excess whitespace 2012-10-31 08:07:49 -07:00
Mattt Thompson
bf1fe2deef Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-10-31 08:01:39 -07:00
Mattt Thompson
1826cffd81 Renaming parseOptions property to JSONReadingOptions 
Updating documentation for JSONReadingOptions property
 2012-10-31 08:01:22 -07:00
Jeremy Foo
5d37e534f7 Updates AFJSONRequestOperation to allow JSON parsing options since it is now using the NSJSONSerialization class by default 2012-10-31 07:57:16 -07:00
Mattt Thompson
b39dc966d6 Merge pull request #588 from natestedman/master 
Add Github's Obj-C .gitignore
 2012-10-31 07:55:38 -07:00
Mattt Thompson
4b2c2818a1 Using conventional weak/strong self pattern to break retain cycle in background tasks 2012-10-31 07:49:44 -07:00
Mattt Thompson
953dfbcfbc Using __weak reference in setCompletionBlock: 2012-10-31 07:45:13 -07:00
Jerry Beers
c3bc36abd7 Break retain cycle for background tasks 2012-10-31 07:43:34 -07:00
Mattt Thompson
652ad787e7 Minor reformatting of weak/strong self pattern for network reachability callbacks 2012-10-31 07:42:19 -07:00
Mattt Thompson
ecac2b3583 Merge pull request #612 from Madefire/afhttpclient_no_dealloc 
fix for AFHTTPClient not being released
 2012-10-31 07:36:18 -07:00
Dan Weeks
e549ee33a9 use the weakself/strongself pattern to fix AFHTTPClient not being released 
see AFNetworking issue #581
 2012-10-30 11:58:54 -07:00
Mattt Thompson
30523b1b73 Merge pull request #602 from modocache/fix-xml-typo 
Fix typo in AFXMLRequestOperation block.
 2012-10-26 20:29:43 -07:00
modocache
8967359d36 Fix typo in AFXMLRequestOperation block. 2012-10-25 11:47:15 -04:00
Mattt Thompson
3f6571dc83 Merge pull request #598 from dtorres/patch-1 
Set the dot (.) to be unescaped (fixes #597)
 2012-10-24 11:33:44 -07:00
Diego Torres
7945e801dc Set the dot (.) to be unescaped (fixes #597) 2012-10-24 15:55:40 -02:00
Mattt Thompson
21c1006761 Merge pull request #594 from ijohn/patch-1 
Update Example/Classes/Models/Post.m
 2012-10-24 09:30:37 -07:00
ijohn
8f898addf2 Update Example/Classes/Models/Post.m 
Sorry the previous commit left 1 crucial line :(
 2012-10-24 13:17:16 +07:00
ijohn
3a80dbc795 Update Example/Classes/Models/Post.m 
Adapt to app.net global stream response change
 2012-10-24 13:09:54 +07:00
Nate Stedman
e8d7a91305 Add Github's Objective-C .gitignore file. 
This prevents .DS_Store and xcuserdata files/dirs from causing
the AFNetworking submodule to always have `(untracked content)`
listed in `git status`.
 2012-10-19 14:25:31 -04:00
Mattt Thompson
4f844a2c3d Merge pull request #587 from andrewsardone/aps-minor-permissions-change 
[Low Priority] Remove executable permission on AFHTTPClient source files
 2012-10-18 09:56:13 -07:00
Andrew Sardone
62e2deddb1 Remove executable permission on AFHTTPClient source files 
For some reason the file mode was changed to add an executable
permission in commit d92462ef8c. This
change is basically inessential housekeeping.
 2012-10-18 10:05:24 -04:00
Mattt Thompson
03b3cdf5e1 Merge pull request #583 from chrismcc/patch-1 
Update README.md
 2012-10-17 09:09:08 -07:00
ckmcc
aaf3da98e1 Update README.md 
* Remove references to autorelease.
* Replace progress NSInteger with NSUInteger.
 2012-10-16 21:51:12 -05:00
Mattt Thompson
1637ee2e67 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-10-16 08:17:50 -07:00
Sylver Bruneau
d61c2ea526 [Issue #579] Fixing last file component in multipart form part creation 2012-10-16 08:17:42 -07:00
Mattt Thompson
d569470ffd Merge pull request #578 from Madefire/64_to_32_conversion 
Avoid warning on implicit 64 to 32 conversion in AFHTTPClient.m
 2012-10-16 08:06:56 -07:00
Dan Weeks
d635972ee5 avoid warning (error with -Werror) on implicit 64 to 32 conversion 2012-10-15 14:12:16 -07:00
Mattt Thompson
4d7e33a0b7 Updating podspec to 1.0 2012-10-14 11:42:59 -07:00
Mattt Thompson
6136d59b15 Updating README 2012-10-14 11:41:51 -07:00
Mattt Thompson
1715163d20 Updating changelog to 1.0 2012-10-14 11:36:25 -07:00
Mattt Thompson
3dcc97ec8e Minor updates to AFURLConnectionOperation documentation 2012-10-14 10:41:37 -07:00
Mattt Thompson
73f994472f Using consistent urlRequest parameter name in AFHTTPClient 2012-10-14 10:22:40 -07:00
Mattt Thompson
a6870bd366 Minor reorganization & cleanup 2012-10-14 10:07:13 -07:00
Mattt Thompson
6f999cdeff NSCParameterAssert -> NSParameterAssert 2012-10-14 10:06:50 -07:00
Mattt Thompson
424c026f0c Twitter shut off its unauthorized access to the public timeline; switching example over to the App.net global stream. 2012-10-10 20:08:34 -07:00
Mattt Thompson
ddf43e1122 Revert "Using NS_ENUM in place of typedef enum" 
This reverts commit ae1d419cd4.
 2012-10-09 17:38:08 -07:00
Mattt Thompson
ae1d419cd4 Using NS_ENUM in place of typedef enum 2012-10-09 09:46:30 -07:00
Mattt Thompson
e8b3e27043 Replacing existing property ownership values of retain with strong 2012-10-09 09:26:50 -07:00
Mattt Thompson
cd2171cc5c [Issue #569] Adding missing ownership field in JSON properties 2012-10-09 09:20:18 -07:00
Mattt Thompson
bad206b41f [Issue #465] Instead of enforcing non-nil parameter, allow it to signify not appending a path to the base URL when matching 2012-10-09 09:14:26 -07:00
Mattt Thompson
a2e0453cda Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-10-09 09:10:34 -07:00
Mattt Thompson
d3ae3d128f [Issue #465] Enforcing non-nil path constraint, and making it so that path is relative to the path of the client baseURL 
[Issue #465] Providing additional explanation about how to manage the lifecycle of enqueued operations
 2012-10-09 09:10:23 -07:00