Commit graph

1255 commits

Author SHA1 Message Date
Cédric Luthi
4b17ec6b51 Compare NSURLRequest rather than NSURL
If you inadvertently load a nil URL in UIImageView+AFNetworking, the failure block of the image request operation is bypassed because [nil isEqual:nil] == NO. By comparing the URL request instead of the URL, the `isEqual:` test passes and the error is properly forwarded to the failure block parameter.
2013-02-01 12:23:26 +01:00
Oliver Jones
22c7d4ec96 Fixes warning: weak receiver may be unpredictably set to nil [-Wreceiver-is-weak]
Signed-off-by: Mattt Thompson <m@mattt.me>
2013-02-01 02:45:36 +00:00
Oliver Jones
8558d4d5f0 Fixes warning: multiple methods named 'objectForKey:' found [-Wstrict-selector-match] 2013-02-01 02:43:12 +00:00
Oliver Jones
6b8cdf1581 Fixes warning: multiple methods named 'postNotificationName:object:' found [-Wstrict-selector-match] 2013-02-01 02:42:58 +00:00
Mattt Thompson
74da4493f2 Wrapping AFHTTPBodyPart switch statement with #pragma to ignore -Wcovered-switch-default 2013-02-01 02:39:02 +00:00
Mattt Thompson
be72f5fe1f [Issue #767] Consolidating macros 2013-01-31 07:06:26 +00:00
Mattt Thompson
26da1ad95a Merge branch 'master' of https://github.com/Fl0p/AFNetworking into Fl0p-master 2013-01-31 07:02:51 +00:00
Mattt Thompson
e969fcd904 Cleaning up formatting from pull request
Adding @dynamic for lock property
2013-01-31 07:00:03 +00:00
Mattt Thompson
3efe3742f1 Merge pull request #768 from jparise/response-json-lock
Serialize calls to responseJSON using a lock.
2013-01-30 22:56:53 -08:00
Mattt Thompson
c790135fd4 Updating OS X project settings 2013-01-31 06:55:04 +00:00
Mattt Thompson
0f794ccfc9 [Issue #769] Resolving asymmetry in cached image case for UIImageView category 2013-01-31 06:54:45 +00:00
Jon Parise
0dbff8387b Serialize calls to responseJSON using a lock.
AFJSONRequestOperation's completion path calls `responseJSON` from a
processing queue.  Because `responseJSON` "lazily" deserializes the
response data into a JSON object, it needs to be protected against
concurrent access from other queues (threads).

For example, `AFNetworkingOperationDidFinishNotification` is posted
when the operation finishes but perhaps before that processing queue
has finishing executing.  Notification observers who also access
`responseJSON` end up in a race with that queue that often leads to a
crash.

We reuse the existing lock from our AFURLConnectionOperation base
class.
2013-01-30 12:25:22 -08:00
flop
d998515d24 Fix [Issue #751] 2013-01-30 21:52:13 +03:00
Kevin Harwood
9ba4838862 Added in a property to handle invalid SSL certs 2013-01-30 10:26:01 -06:00
Mattt Thompson
eac6ffbb6e Revert "Fixing warning caused by default statement in switch statement that covered all enumeration values"
This reverts commit b5c48f13a1.
2013-01-30 16:25:56 +00:00
Mattt Thompson
b5c48f13a1 Fixing warning caused by default statement in switch statement that covered all enumeration values 2013-01-29 15:31:16 +00:00
Mattt Thompson
b70be414b7 Fixing @param name to correspond to actual parameter (filename -> fileName) 2013-01-29 15:31:12 +00:00
Mattt Thompson
2c55ad7abc Merge branch 'experimental-issue-738'
Conflicts:
	AFNetworking/AFURLConnectionOperation.m
2013-01-27 13:26:04 -05:00
Mattt Thompson
83da1edd13 Whitespace formatting by Xcode re-indentation 2013-01-27 12:15:07 -05:00
Mattt Thompson
317dd753d9 [Issue #737] Updating default Accept-Language header value in AFHTTPClient 2013-01-26 11:32:13 -05:00
Mattt Thompson
6e69da9feb Using early return in AFURLConnectionOperation -setState: to avoid posting notifications in lock 2013-01-26 10:47:11 -05:00
Mattt Thompson
d9da9e5c1a Whitespace formatting 2013-01-26 10:31:16 -05:00
Mattt Thompson
cd8cee4ac8 Enqueuing operation in upload example rather than calling -start directly 2013-01-25 08:56:43 -05:00
Mattt Thompson
349534188a Merge pull request #747 from peymano/race-condition-fix-in-uiimageview
Fix race condition in UIImageView+AFNetworking
2013-01-24 14:05:52 -08:00
Mattt Thompson
13cb42e00d Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-01-24 17:02:22 -05:00
Mattt Thompson
6a11c82120 Suppressing warning caused by AFHTTPBodyPart -hasBytesAvailable not having default condition in switch statement 2013-01-24 17:01:25 -05:00
Mattt Thompson
1368e618a6 [Issue #751] Removing NSURLConnectionDataDelegate from AFURLConnectionOperation's declared protocols 2013-01-24 17:00:27 -05:00
Peyman
b337828e96 Fix race condition in UIImageView+AFNetworking 2013-01-21 14:11:26 -08:00
Mattt Thompson
ba9185ded2 Merge pull request #743 from 0xced/NSURL-user-password
Use NSURL methods instead of CFURL functions
2013-01-20 21:08:48 -08:00
Cédric Luthi
7abc97881e Rename the username variable to user 2013-01-18 15:08:29 +01:00
Cédric Luthi
74346addea Use NSURL methods instead of CFURL functions
* Replace CFURLCopyUserName with -[NSURL user]
* Replace CFURLCopyPassword with -[NSURL password]
2013-01-18 15:06:14 +01:00
Mattt Thompson
c79a2c87a8 Update README.md 2013-01-16 07:54:27 -08:00
Mattt Thompson
2b8be998ce Fixing center alignment 2013-01-16 07:46:10 -08:00
Mattt Thompson
46bc122deb Fixing link to diagram in README 2013-01-16 07:43:15 -08:00
Mattt Thompson
9173264a3f Adding AFNetworking architecture diagram 2013-01-16 07:42:36 -08:00
Mattt Thompson
965b3670a7 Updating list of implemented NSURLConnectionDelegate method 2013-01-06 20:46:08 -08:00
Mattt Thompson
9aeb38649b [Issue #719] Adding shouldUseCredentialStorage property to AFURLConnectionOperation /thanks Xihe Yu 2013-01-06 20:44:48 -08:00
Mattt Thompson
1e7c45c191 Marking connection parameter in connection:needNewBodyStream: as __unused 2013-01-06 20:39:59 -08:00
Mattt Thompson
b66c21b0f2 Re-ordering NSURLConnectionDelegate method implementations 2013-01-05 23:48:48 -08:00
Mattt Thompson
23d3bd5af4 Minor reformatting 2013-01-05 23:40:34 -08:00
Mattt Thompson
77471bb994 Merge branch 'stream_exhausted_fix' of https://github.com/aburgel/AFNetworking into aburgel-stream_exhausted_fix 2013-01-05 23:32:36 -08:00
Mattt Thompson
b7ec92850a [Issue #715] Fixing warnings generated by earlier versions of Xcode (/cc Ignacio Rodrigo)
Minor reformatting
2013-01-05 22:19:59 -08:00
Alex Burgel
ecf6899d5f Fix request stream exhaustion error by copying the original NSInputStream 2013-01-05 15:10:47 -05:00
Mattt Thompson
6cf45650e2 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-01-04 12:56:53 -08:00
Mattt Thompson
c6137914fa Adding AFHTTPClient -setDefaultCredential: 2013-01-04 12:52:14 -08:00
Mattt Thompson
1d243f7794 Adding credential property to AFURLConnectionOperation 2013-01-04 12:41:25 -08:00
Mattt Thompson
0c74a59a3e Merge pull request #713 from ericflo/patch-1
Added single quote to the chars to escape
2013-01-04 09:38:28 -08:00
Eric Florenzano
a610a89f8c Added single quote to the chars to escape
Ran into some issues with sending an unescaped apostrophe,
but by adding it to the list of characters to escape, this problem
is now fixed for me.
2013-01-03 17:53:30 -08:00
Oliver Letterer
80bb2ea527 Gets rid of for loop to check if public key is present. 2012-12-29 13:10:14 +01:00
Oliver Letterer
3b1a098701 Fixes memory leak. 2012-12-29 13:06:52 +01:00