Oliver Jones
23b8fe33ba
Fixes warning: weak receiver may be unpredictably null in ARC mode [-Werror,-Wreceiver-is-weak]
2012-11-29 18:30:28 +11:00
Oliver Jones
f9449753ff
Fixes warning: property is assumed atomic by default [-Werror,-Wimplicit-atomic-properties]
2012-11-29 18:06:05 +11:00
Oliver Jones
debd442903
Fixes warning: unused parameter 'x' [-Werror,-Wunused-parameter]
2012-11-29 18:03:34 +11:00
Oliver Jones
3486a008a1
Fixing warnings: implicit conversion changes signedness: 'NSInteger' (aka 'long') to 'unsigned long' [-Werror,-Wsign-conversion]
2012-11-29 17:53:30 +11:00
Nick Forge
3175869333
Fixed retain cycles in AFImageRequestOperation.m and AFHTTPClient.m caused by strong references within blocks
...
These retain cycles started showing up as compiler warnings after upgrading to Xcode 4.6DP
2012-11-21 15:48:18 +11:00
Mattt Thompson
402e460023
Changing order of conditional check to match responseString
2012-11-15 10:20:21 -08:00
Mattt Thompson
92134e92c3
Merge branch 'master' of github.com:AFNetworking/AFNetworking
2012-11-15 10:10:48 -08:00
Mattt Thompson
000010f850
Adding missing scan of '/' separator in content type string
2012-11-15 10:05:55 -08:00
Jorge Bernal
db8941f1ba
[Issue #638 ] Following guidelines from RFC 2616 regarding the use of string encoding when none is specified in the response
...
Signed-off-by: Mattt Thompson <m@mattt.me>
2012-11-15 09:53:53 -08:00
Cédric Luthi
f106d19536
Use NSLocalizedStringFromTable with AFNetworking.strings table for localized strings
2012-11-14 17:44:11 +01:00
Mattt Thompson
eaac6a1759
[Issue #640 ] Removing documentation note about default Accept-Encoding header
2012-11-12 21:44:29 -08:00
Tomohisa Takaoka
c92f306c6d
Issue: Timeout when buffer ends during ending boundry
2012-11-09 14:23:51 -08:00
Mattt Thompson
247863cfc2
[Issue #633 ] Manually casting scalar types in initWithCoder for AFURLConnectionOperation and AFHTTPClient
2012-11-09 07:31:53 -08:00
Mattt Thompson
ff8e70a49c
Using addOperations:waitUntilFinished: instead of adding each operation individually in -enqueueBatchOfHTTPRequestOperations:... to fix an edge case bug where only one of the operations in a batch will run.
2012-11-06 12:03:19 -08:00
Mattt Thompson
24dfebb424
Merge branch 'master' of github.com:AFNetworking/AFNetworking
2012-11-06 09:22:04 -08:00
Mattt Thompson
5ec794dc4d
Indenting macro conditionals
2012-11-06 09:21:41 -08:00
Mattt Thompson
d5bd23ca17
Distinguisging between CoreServices and MobileCoreServices for #warning
2012-11-06 09:13:22 -08:00
Mattt Thompson
a495902c65
Removing quotes for #warning macros
2012-11-06 09:10:22 -08:00
Cédric Luthi
db10b25bb2
Derive keys string representations using the description method as specified in AFQueryStringFromParametersWithEncoding documentation
2012-11-06 15:16:48 +01:00
Christian Rasmussen
940f42dade
[ #624 ] Moved __unused keywords for better Xcode indexing.
2012-11-05 21:33:56 +01:00
Mattt Thompson
5b32b45469
[Issue #619 ] Sorting dictionary keys with caseInsensitiveCompare to ensure deterministic ordering of query string parameters, which may otherwise cause ambiguous representations of nested parameters
2012-11-05 12:03:23 -08:00
Stan Chang Khin Boon
2fde59c3fd
[Issue #591 ] Attempts to fix crash caused by incorrect calculation of range when reading data into buffer.
...
When the current buffer isn't large enough to store the data,
AFNetworking attempts to fill the current buffer with as much data as
it can holds and leaves the remaining data to the next buffer.
There is a bug when calculating the range to read from data in the next
buffer. The `_phaseReadOffset` is set correctly but the `[data length]`
is not adjusting correctly to the offset. This causes `getBytes:range:`
to complains that it attempts to get bytes that are out of range.
An attempted fix is done here by adjusting the range (Also adjust to
check against `_phaseReadOffset` instead of `range.length`.
As I am modifying some critical section, a detail review might be
required.
I am sending this pull request so as to facilitiate the review process,
but if you are already in review of the issue and the solution, you can
ignore my pull and close it. Thanks!
Detail explanation of how the solution come about can be found here:
https://github.com/AFNetworking/AFNetworking/issues/591#issuecomment-993
0763
2012-11-01 02:42:14 +08:00
Mattt Thompson
e2f2ab45aa
[Issue #599 ] Refactoring AFHTTPClient to remove unnecessary JSON / plist serialization functions, logging any error that may arise.
2012-10-31 09:55:18 -07:00
Mattt Thompson
175c3fa451
[Issue #565 ] Checking for kCFStringEncodingInvalidId from CFStringConvertIANACharSetNameToEncoding() before getting NSStringEncoding with CFStringConvertEncodingToNSStringEncoding, which may otherwise lead to unexpected behavior
2012-10-31 08:37:47 -07:00
Mattt Thompson
d31e23af29
[Issue #603 ] Removing duplicated runloop scheduling of outputStream
2012-10-31 08:27:10 -07:00
Mattt Thompson
81f33ae971
[Issue #592 ][Issue #600 ] Changes the logic of UIImageView -setImageWithURLRequest:placeholderImage:success:failure: such that if the success block is specified, the default behavior of self.image = image is not executed. This allows for full customization over any post-processing on the image, or the animation to be used when setting the image.
2012-10-31 08:20:58 -07:00
Mattt Thompson
ebc9f7d50e
Removing excess whitespace
2012-10-31 08:07:49 -07:00
Mattt Thompson
1826cffd81
Renaming parseOptions property to JSONReadingOptions
...
Updating documentation for JSONReadingOptions property
2012-10-31 08:01:22 -07:00
Jeremy Foo
5d37e534f7
Updates AFJSONRequestOperation to allow JSON parsing options since it is now using the NSJSONSerialization class by default
2012-10-31 07:57:16 -07:00
Mattt Thompson
4b2c2818a1
Using conventional weak/strong self pattern to break retain cycle in background tasks
2012-10-31 07:49:44 -07:00
Mattt Thompson
953dfbcfbc
Using __weak reference in setCompletionBlock:
2012-10-31 07:45:13 -07:00
Jerry Beers
c3bc36abd7
Break retain cycle for background tasks
2012-10-31 07:43:34 -07:00
Mattt Thompson
652ad787e7
Minor reformatting of weak/strong self pattern for network reachability callbacks
2012-10-31 07:42:19 -07:00
Dan Weeks
e549ee33a9
use the weakself/strongself pattern to fix AFHTTPClient not being released
...
see AFNetworking issue #581
2012-10-30 11:58:54 -07:00
modocache
8967359d36
Fix typo in AFXMLRequestOperation block.
2012-10-25 11:47:15 -04:00
Diego Torres
7945e801dc
Set the dot (.) to be unescaped ( fixes #597 )
2012-10-24 15:55:40 -02:00
Andrew Sardone
62e2deddb1
Remove executable permission on AFHTTPClient source files
...
For some reason the file mode was changed to add an executable
permission in commit d92462ef8c . This
change is basically inessential housekeeping.
2012-10-18 10:05:24 -04:00
Mattt Thompson
1637ee2e67
Merge branch 'master' of github.com:AFNetworking/AFNetworking
2012-10-16 08:17:50 -07:00
Sylver Bruneau
d61c2ea526
[Issue #579 ] Fixing last file component in multipart form part creation
2012-10-16 08:17:42 -07:00
Dan Weeks
d635972ee5
avoid warning (error with -Werror) on implicit 64 to 32 conversion
2012-10-15 14:12:16 -07:00
Mattt Thompson
3dcc97ec8e
Minor updates to AFURLConnectionOperation documentation
2012-10-14 10:41:37 -07:00
Mattt Thompson
73f994472f
Using consistent urlRequest parameter name in AFHTTPClient
2012-10-14 10:22:40 -07:00
Mattt Thompson
6f999cdeff
NSCParameterAssert -> NSParameterAssert
2012-10-14 10:06:50 -07:00
Mattt Thompson
ddf43e1122
Revert "Using NS_ENUM in place of typedef enum"
...
This reverts commit ae1d419cd4 .
2012-10-09 17:38:08 -07:00
Mattt Thompson
ae1d419cd4
Using NS_ENUM in place of typedef enum
2012-10-09 09:46:30 -07:00
Mattt Thompson
e8b3e27043
Replacing existing property ownership values of retain with strong
2012-10-09 09:26:50 -07:00
Mattt Thompson
cd2171cc5c
[Issue #569 ] Adding missing ownership field in JSON properties
2012-10-09 09:20:18 -07:00
Mattt Thompson
bad206b41f
[Issue #465 ] Instead of enforcing non-nil parameter, allow it to signify not appending a path to the base URL when matching
2012-10-09 09:14:26 -07:00
Mattt Thompson
d3ae3d128f
[Issue #465 ] Enforcing non-nil path constraint, and making it so that path is relative to the path of the client baseURL
...
[Issue #465 ] Providing additional explanation about how to manage the lifecycle of enqueued operations
2012-10-09 09:10:23 -07:00
Mattt Thompson
b10f66062c
Changing multipartFormRequestWithMethod:... to black-list GET and HEAD rather than whitelist particular methods.
...
Enforcing non-nil, non-GET / HEAD method parameter requirement
2012-10-09 08:59:42 -07:00