Address review feedback

This commit is contained in:
ivmarkov 2023-07-22 17:54:40 +00:00
parent 92b24920ce
commit 50b2433fb5
4 changed files with 16 additions and 13 deletions

View file

@ -18,16 +18,19 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@v2 uses: actions/checkout@v3
- name: Fmt - name: Fmt
run: cd tools/tlv; cargo fmt -- --check run: cargo fmt -- --check
working-directory: tools/tlv
- name: Clippy - name: Clippy
run: cd tools/tlv; cargo clippy --no-deps -- -Dwarnings run: cargo clippy --no-deps -- -Dwarnings
working-directory: tools/tlv
- name: Build - name: Build
run: cd tools/tlv; cargo build run: cargo build
working-directory: tools/tlv
- name: Archive artifacts - name: Archive artifacts
uses: actions/upload-artifact@v2 uses: actions/upload-artifact@v2

View file

@ -10,7 +10,7 @@ on:
workflow_dispatch: workflow_dispatch:
env: env:
rust_toolchain: nightly-2023-07-01 RUST_TOOLCHAIN: nightly-2023-07-01
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CARGO_TERM_COLOR: always CARGO_TERM_COLOR: always
@ -28,21 +28,21 @@ jobs:
if: matrix.toolchain == 'nightly' if: matrix.toolchain == 'nightly'
uses: dtolnay/rust-toolchain@v1 uses: dtolnay/rust-toolchain@v1
with: with:
toolchain: ${{ env.rust_toolchain }} toolchain: ${{ env.RUST_TOOLCHAIN }}
components: rustfmt, clippy, rust-src components: rustfmt, clippy, rust-src
- name: Checkout - name: Checkout
uses: actions/checkout@v2 uses: actions/checkout@v3
- name: Fmt - name: Fmt
run: cargo +${{ matrix.toolchain == 'nightly' && env.rust_toolchain || 'stable'}} fmt -- --check run: cargo +${{ matrix.toolchain == 'nightly' && env.RUST_TOOLCHAIN || 'stable'}} fmt -- --check
- name: Clippy - name: Clippy
run: cargo +${{ matrix.toolchain == 'nightly' && env.rust_toolchain || 'stable'}} clippy --no-deps --no-default-features --features ${{matrix.crypto-backend}},${{matrix.features}},${{ matrix.toolchain == 'nightly' && 'nightly' || ''}} -- -Dwarnings run: cargo +${{ matrix.toolchain == 'nightly' && env.RUST_TOOLCHAIN || 'stable'}} clippy --no-deps --no-default-features --features ${{matrix.crypto-backend}},${{matrix.features}},${{ matrix.toolchain == 'nightly' && 'nightly' || ''}} -- -Dwarnings
- name: Build - name: Build
run: cargo +${{ matrix.toolchain == 'nightly' && env.rust_toolchain || 'stable'}} build --no-default-features --features ${{matrix.crypto-backend}},${{matrix.features}},${{ matrix.toolchain == 'nightly' && 'nightly' || ''}} run: cargo +${{ matrix.toolchain == 'nightly' && env.RUST_TOOLCHAIN || 'stable'}} build --no-default-features --features ${{matrix.crypto-backend}},${{matrix.features}},${{ matrix.toolchain == 'nightly' && 'nightly' || ''}}
- name: Test - name: Test
if: matrix.features == 'os' if: matrix.features == 'os'
run: cargo +${{ matrix.toolchain == 'nightly' && env.rust_toolchain || 'stable'}} test --no-default-features --features ${{matrix.crypto-backend}},${{matrix.features}},${{ matrix.toolchain == 'nightly' && 'nightly' || ''}} -- --test-threads=1 run: cargo +${{ matrix.toolchain == 'nightly' && env.RUST_TOOLCHAIN || 'stable'}} test --no-default-features --features ${{matrix.crypto-backend}},${{matrix.features}},${{ matrix.toolchain == 'nightly' && 'nightly' || ''}} -- --test-threads=1

View file

@ -11,7 +11,7 @@ jobs:
uses: actions/checkout@v3 uses: actions/checkout@v3
- name: Login - name: Login
run: cargo login ${{ secrets.crates_io_token }} run: cargo login ${{ secrets.CRATES_IO_TOKEN }}
- name: Publish-Macros - name: Publish-Macros
run: cargo publish -p rs-matter-macros run: cargo publish -p rs-matter-macros

View file

@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@v3 uses: actions/checkout@v3
- name: Login - name: Login
run: cargo login ${{ secrets.crates_io_token }} run: cargo login ${{ secrets.CRATES_IO_TOKEN }}
- name: Publish - name: Publish
run: cargo publish -p rs-matter run: cargo publish -p rs-matter