asklyphe-public/asklyphe
asklyphe-public/asklyphe
1
0
Fork 1
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions

feat: implement bangs #13

Open
ChaoticCreature wants to merge 9 commits from ChaoticCreature/asklyphe:develop into develop
pull from: ChaoticCreature/asklyphe:develop
merge into: asklyphe-public:develop
Conversation 2 Commits 9 Files changed 3 +118
ChaoticCreature commented 2025-05-08 01:24:48 -07:00
First-time contributor
Copy link

It's been over a year since I've use rust so please let me know if I've made any terrible mistakes or if you want me to make any other changes.

I tried to implement bangs as close to the functionality provided by both duckduckgo and waterfox with multiple aliases for one website, only redirecting to & removing the first bang encountered, removing extra spaces surrounding the bangs, etc.

it should be pretty simple to extend with new bangs and not require a massive refactor to eventually implement a settings menu with toggles/creating new ones.

The key in the hashmap is the vanity name/whatever it's called that could be used in some future settings menu list, but for now it's useless

epic demonstration video:

https://forge.voremicrocomputers.com/attachments/5cf6a844-1f0c-4233-9675-af09459d9140

It's been over a year since I've use rust so please let me know if I've made any terrible mistakes or if you want me to make any other changes. I tried to implement bangs as close to the functionality provided by both duckduckgo and waterfox with multiple aliases for one website, only redirecting to & removing the first bang encountered, removing extra spaces surrounding the bangs, etc. it should be pretty simple to extend with new bangs and not require a massive refactor to eventually implement a settings menu with toggles/creating new ones. The key in the hashmap is the vanity name/whatever it's called that could be used in some future settings menu list, but for now it's useless epic demonstration video: https://forge.voremicrocomputers.com/attachments/5cf6a844-1f0c-4233-9675-af09459d9140
faster.mp4
2.2 MiB
ChaoticCreature added 9 commits 2025-05-08 01:24:48 -07:00
ChaoticCreature commented 2025-05-08 02:35:22 -07:00
Author
First-time contributor
Copy link

I spent too long thinking and now I'm not sure if it's really a good idea to use the hashmap and if I should instead use a Vec & include the name in the struct/remove it and add it back if needed.

If you think that would be better I can change it :3

I spent too long thinking and now I'm not sure if it's really a good idea to use the hashmap and if I should instead use a Vec & include the name in the struct/remove it and add it back if needed. If you think that would be better I can change it :3
ChaoticCreature commented 2025-05-20 17:30:53 -07:00
Author
First-time contributor
Copy link

@husky Pls review when u have time, lyphe would become so much more bangin' if this was merged :3

@husky Pls review when u have time, lyphe would become so much more bangin' if this was merged :3
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u develop:ChaoticCreature-develop
git checkout ChaoticCreature-develop

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout develop
git merge --no-ff ChaoticCreature-develop
git checkout ChaoticCreature-develop
git rebase develop
git checkout develop
git merge --ff-only ChaoticCreature-develop
git checkout ChaoticCreature-develop
git rebase develop
git checkout develop
git merge --no-ff ChaoticCreature-develop
git checkout develop
git merge --squash ChaoticCreature-develop
git checkout develop
git merge --ff-only ChaoticCreature-develop
git checkout develop
git merge ChaoticCreature-develop
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: asklyphe-public/asklyphe#13
No description provided.
Delete branch "ChaoticCreature/asklyphe:develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?