Changing connection property from retain to assign, to avoid retain cycle caused by NSURLConnection retaining its delegate

This commit is contained in:
Mattt Thompson 2011-11-22 20:57:39 -06:00
parent b5849ccd66
commit a912382431

View file

@ -54,7 +54,7 @@ static inline NSString * AFKeyPathFromOperationState(AFOperationState state) {
@interface AFURLConnectionOperation ()
@property (readwrite, nonatomic, assign) AFOperationState state;
@property (readwrite, nonatomic, assign, getter = isCancelled) BOOL cancelled;
@property (readwrite, nonatomic, retain) NSURLConnection *connection;
@property (readwrite, nonatomic, assign) NSURLConnection *connection;
@property (readwrite, nonatomic, retain) NSURLRequest *request;
@property (readwrite, nonatomic, retain) NSURLResponse *response;
@property (readwrite, nonatomic, retain) NSError *error;
@ -133,9 +133,7 @@ static inline NSString * AFKeyPathFromOperationState(AFOperationState state) {
[_responseString release];
[_dataAccumulator release];
[_outputStream release]; _outputStream = nil;
[_connection release]; _connection = nil;
[_uploadProgress release];
[_downloadProgress release];