evie/AFNetworking
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1449 commits 1 branch 0 tags 2.4 MiB
Commit graph

1449 commits

This branch
This branch
All branches
Author SHA1 Message Date
Josh Chung
5c237a66eb call SecTrustEvaluate before calling SecTrustGetCertificateCount 
SecTrustGetCertificateCount's documentation says SecTrustEvaluate must be called before calling it. Without calling it, SecTrustGetCertificateCount returns 0 in OS X 10.7.
 2014-04-14 17:13:24 +09:00
Mattt Thompson
d74e568cf2 Merge pull request #1888 from indragiek/1.x 
Same fix as 6c7250e for 1.x branch
 2014-03-11 03:05:26 -07:00
Indragie Karunaratne
ab08e149e2 Same fix as 6c7250e for 1.x branch 
Wrapping OSStatus and NSCAssert with NS_BLOCK_ASSERTIONS macro to prevent unused variable
 2014-03-10 22:09:02 -06:00
Mattt Thompson
4fa43bd41c Merge pull request #1866 from CFKevinRef/1.x 
Check CFStringTransform() call for success before using result
 2014-03-05 08:44:23 -08:00
Kevin Cassidy Jr
24816f52a4 Check CFStringTransform() call for success before using result 2014-02-28 14:00:04 -05:00
Mattt Thompson
353163c09c Merge pull request #1764 from doo/ake-fix-warnings 
Fix two warnings that show up recently
 2014-01-21 08:28:17 -08:00
Alexander Kempgen
6aa3346e98 Don't use NSUInteger as format argument, add explicit cast instead 2014-01-21 16:07:21 +01:00
Alexander Kempgen
a89fede6dd Remove unused variable 'kAFStreamToStreamBufferSize' 2014-01-21 16:07:21 +01:00
Mattt Thompson
ebe5c7af31 Merge pull request #1450 from mdornseif/pinningNoKeyWarning_1.x 
1.x: Assert that no impossible pinning configuration exists
 2013-10-10 19:29:40 -07:00
Mattt Thompson
e18e4e01bc Merge pull request #1451 from mdornseif/pinningWarning_1.x 
1.x: Give a human readable Warning when SSL Pinning fails.
 2013-10-10 19:28:04 -07:00
Maximillian Dornseif
4f5245a7ce Assert that no impossible pinning configuration exists 
If you use certificate pinning you MUST provide at least
one certificate/key file within the application bundle.
If you don't, you will not be able to preform any
successfull network requests.

I have been bitten several times by not correctly
including a Certificate/Key in the bundle and spend
far too much time debugging this.

This two assertations catch this programming error.
Not including a Certificate/Key in the bundle while
demanding pinning is obviously a programming error
and not a runtime issue.

Hope this helps a tiny bit to get more widespread
adoption of certificate pinning.
 2013-10-05 10:15:01 +02:00
Maximillian Dornseif
f14d054db7 Give a human readable Warning when SSL Pinning fails. 
Encryption, SSL and Certificates are hard to gasp.
And generally errors like "The operation couldn’t be completed.
(NSURLErrorDomain error -1012.)" are hard to make sense of.

I subscribe to the theory that if you enable SSL Pinning
and it fails, something went horribly wrong
a) you misconfigured the thing, a certificate expired or
   some other developer screw up.
b) your application is unter attack.

Both secenarios warrant a clear and obvious message in the
log files. This breaks with the "no logging" approach in
AFURLConnectionOperation and maybe an `NSAssert` would
be better but if SSP pinning fails something fishy is going
on and we should leave some obvious evidence about this.
 2013-10-03 09:57:58 +02:00
Mattt Thompson
9fd6fea066 Revert "[Issue #1206] Fixing checks for network reachability flags over WWAN" 
This reverts commit 7117142321.
 2013-09-26 14:50:03 -07:00
Mattt Thompson
ce1ebf3038 Bumping version to 1.3.3 2013-09-25 16:01:53 -07:00
Mattt Thompson
7117142321 [Issue #1206] Fixing checks for network reachability flags over WWAN 2013-09-25 11:55:14 -07:00
Mattt Thompson
d1b64cf0bc [Issue #1288] Adding loop around write to ensure entire length of data is written 2013-09-24 15:40:13 -07:00
Mattt Thompson
8a5f3ef359 [Issue #1093] Handling stream errors for AFMultipartBodyStream 2013-09-24 15:35:22 -07:00
Mattt Thompson
d587521451 [Issue #1288] Improving implementation of connection:didRecieveData: to handle case where stream -hasSpaceAvailable returns NO by polling. For in-memory buffers, this will almost never happen. 
[Issue #1093] Handling stream errors in connection:didRecieveData:
 2013-09-24 13:27:37 -07:00
Mattt Thompson
ca1737c5e0 [Issue #887] [Issue #1096] Removing implementation of connection:needNewBodyStream: 2013-09-24 12:53:22 -07:00
Mattt Thompson
9faa5ba2b6 Fixing merge in 52ad3f8380 2013-09-24 12:38:46 -07:00
Mattt Thompson
52ad3f8380 Merge branch 'bracket-pull-request' of github.com:opentable/AFNetworking into opentable-bracket-pull-request 
Conflicts:
	AFNetworking/AFHTTPClient.m
 2013-09-24 12:36:34 -07:00
Mattt Thompson
c413b141b6 [Issue #1241] Fixing potential race condition in cancelConnection 2013-09-24 12:15:38 -07:00
Blake Watters
ffd9079da2 Build and run unit tests against the iOS 5.0 SDK to validate minimum deployment target compatibility 2013-09-24 12:00:28 -07:00
Mattt Thompson
99f77d1381 [Issue #1217] Cutting the knot with respect to API compatibility 2013-09-24 11:59:31 -07:00
Mattt Thompson
44915d5173 Merge pull request #1265 from 0xced/Wassign-enum-master 
Cast instead of #pragma clang diagnostic ignored "-Wassign-enum"
 2013-08-28 11:13:44 -07:00
Cédric Luthi
776c879c9d Cast instead of #pragma clang diagnostic ignored "-Wassign-enum" 2013-08-28 12:08:24 +02:00
Mattt Thompson
f06160b663 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-08-25 11:34:48 -07:00
Flávio Caetano
1753b29bd2 Enabling invalid SSL certificates on UIImageView+AFNetworking 
Conflicts:

	Tests/Podfile.lock
 2013-08-25 11:34:28 -07:00
Mattt Thompson
a179c7fd33 Merge pull request #1240 from guitcastro/master 
removed memory leak
 2013-08-23 08:57:14 -07:00
Mattt Thompson
9c23a1955c Revert "When AFNetworking is in an embedded framework, load certificates from all non-framework bundles" 
This reverts commit ad0d0cd46e.
 2013-08-21 13:35:18 -07:00
Guilherme Torres Castro
3736591f73 removed memory leak 2013-08-21 15:11:37 -03:00
Mattt Thompson
a27c543314 Use string literal instead of building mutable string 2013-08-20 16:53:21 -07:00
Mattt Thompson
0371e366ab Minor reformatting 2013-08-20 16:45:17 -07:00
Mattt Thompson
f0ba01ffd4 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-08-20 16:44:47 -07:00
Mattt Thompson
b43017257d Removing use of unsupported method enumerateByteRangesUsingBlock: 2013-08-20 16:44:37 -07:00
Mattt Thompson
e04296a397 Merge pull request #1216 from paulmelnikow/load_certificates_from_main_bundle 
When AFNetworking is in an embedded framework, load pinned certificates from app bundle
 2013-08-20 16:38:20 -07:00
Mattt Thompson
f891264228 Refactoring upload input stream test and AFBufferedInputStreamProvider class 2013-08-20 16:32:20 -07:00
Mattt Thompson
9f00255677 Merge branch 'master' of https://github.com/xtreme-brian-croom/AFNetworking into xtreme-brian-croom-master 2013-08-20 15:47:23 -07:00
Mattt Thompson
2b8acb7c3f [Issue #1221] Refactoring lock for HTTP error 2013-08-20 15:17:00 -07:00
Mattt Thompson
7562fce4b9 Merge pull request #1221 from OliverLetterer/race-2 
[Race] Fixing AFHTTPRequestOperation.HTTPError being overreleased.
 2013-08-20 15:13:22 -07:00
Oliver Letterer
c4d8a12496 Now using AFURLConnectionOperation.lock for AFHTTPRequestOperation.HTTPError 2013-08-20 10:04:31 +02:00
Oliver Letterer
e867c922a7 Making AFHTTPRequestOperation.HTTPError atomic. 2013-08-15 22:36:48 +02:00
Paul Melnikow
ad0d0cd46e When AFNetworking is in an embedded framework, load certificates from all non-framework bundles 2013-08-12 03:11:17 -04:00
Paul Melnikow
6b2515d8c0 When AFNetworking is in an embedded framework, load certificates from app bundle 2013-08-12 00:22:02 -04:00
Mattt Thompson
ac330c84c8 Revert "Drop Podfile.lock from Git so that we don't have to deal with updating it as revisions change" 
This reverts commit 56625c466e.
 2013-08-10 18:07:01 -07:00
Mattt Thompson
786b1ef36f Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-08-10 17:55:46 -07:00
Mattt Thompson
95a51a4ce6 Merge pull request #1214 from blakewatters/drop-podfile-lock 
Drop Podfile.lock from Git
 2013-08-10 17:51:37 -07:00
Mattt Thompson
748260af04 [Issue #1181] Using UIImage calculated image orientation 
Minor refactoring
 2013-08-10 17:49:05 -07:00
Blake Watters
56625c466e Drop Podfile.lock from Git so that we don't have to deal with updating it as revisions change 2013-08-10 20:38:23 -04:00
Mattt Thompson
c8bd94721e Merge pull request #1212 from carsonmcdonald/fixpodlock132 
Update Podfile.lock to 1.3.2
 2013-08-10 16:44:11 -07:00