Commit graph

1085 commits

Author SHA1 Message Date
Joel Parsons
6a46815eaf The documentations states registered operation classes are consulted to the reverse order in which they are registered. New registrations are added to the beginning of the array in the register implementation. Fixed using the reverseObjectEnumerator when iterating the array which produced the opposite of documented behaviour. fixes #794 2013-03-11 13:15:19 +00:00
Mattt Thompson
4732be728e Merge pull request #841 from 0xced/indentation-settings
Set indentation settings to four spaces at the project level
2013-03-10 11:19:14 -07:00
Mattt Thompson
48ca0846bb Merge pull request #842 from 0xced/no-nil-network-activity
Update network activity indicator only if requests have a non nil URL
2013-03-10 11:17:28 -07:00
Mattt Thompson
27c357a6c3 Merge pull request #843 from blakewatters/bugfix/avoid-logging-crashes-from-notifications
Rework Notification Delivery to Avoid Crashes in Logging
2013-03-10 11:15:37 -07:00
Cédric Luthi
9c3530060c Update network activity indicator only if requests have a non nil URL 2013-03-07 13:20:58 +01:00
Cédric Luthi
95b4f6c979 Set indentation settings to four spaces at the project level 2013-03-07 12:53:47 +01:00
Blake Watters
db305db733 Rework delivery of AFNetworkingOperationDidStartNotification and AFNetworkingOperationDidFinishNotification to avoid crashes when logging in response to notifications 2013-03-06 21:40:56 -05:00
Mattt Thompson
61188e2dad [Issue #837] Refactoring implementation of HTTP string encoding edge case to -responseStringEncoding to fix potential inconsistency in effective value 2013-03-05 14:42:23 -08:00
Mattt Thompson
2b6590d800 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-02-27 11:20:20 -08:00
Sean Kovacs
b42ea1fdb6 [Issue #803] Only set image in UIImageView category if non-nil
Signed-off-by: Mattt Thompson <m@mattt.me>
2013-02-27 11:11:49 -08:00
Mattt Thompson
8658013d58 Merge pull request #814 from madninja/bug/percent-escapes
Adding comma (,) as a percent escaped character
2013-02-27 10:48:07 -08:00
Mattt Thompson
7673c3e1d0 [Issue #817] Removing unused totalContentLength and offsetContentLength properties, and implementation of -connection:didReceiveResponse: 2013-02-27 09:55:07 -08:00
Mattt Thompson
dbd5fc3220 Adding missing #pragma clang diagnostic pop (/thanks @tewha) 2013-02-27 09:24:18 -08:00
Mattt Thompson
c3e70f9948 Merge pull request #825 from OliverLetterer/thread-issue
Fixes -[AFURLConnectionOperation totalBytesRead] threading issue.
2013-02-27 08:36:47 -08:00
Oliver Letterer
580c547616 Fixes -[AFURLConnectionOperation totalBytesRead] threading issue. 2013-02-26 08:37:18 +01:00
Marc Nijdam
63e5f0b57a Adding comma (,) as a percent escaped character since it's in the reserved words per the RFC 2013-02-19 16:01:01 -08:00
Mattt Thompson
cb3744a808 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-02-09 20:22:06 +01:00
Mattt Thompson
caa9551ae4 [Issue #791] Matching operations on request URL path rather than absolute URL string 2013-02-09 19:36:37 +01:00
Mattt Thompson
284b95006e Merge pull request #792 from zachwaugh/master
Fix content type for extension from returning null
2013-02-09 09:44:40 -08:00
Zach Waugh
a563b61a34 Ensure content type for path extension doesn't return null 2013-02-09 11:49:06 -05:00
Mattt Thompson
f0be1ed682 Merge pull request #786 from tewha/patch-9
Fixed comment typo
2013-02-08 00:41:48 -08:00
Steven Fisher
b3625ebcd0 Fixed comment typo
Minor typo.
2013-02-07 14:19:54 -08:00
Mattt Thompson
2cd283421f Merge pull request #778 from Neonkoala/master
Support for repeated key value pairs in URL encoded forms
2013-02-06 03:42:07 -08:00
Nick Dawson
5698ab3768 Added support for repeated key value pairs through use of NSSet 2013-02-05 12:46:03 +00:00
Sasmito Adibowo
ba60cab1be Use dispatch_once to initialize content-type-specific processing queues
Signed-off-by: Mattt Thompson <m@mattt.me>
2013-02-04 00:45:35 +01:00
Mattt Thompson
87c8c776d9 Using DISPATCH_QUEUE_CONCURRENT for all calls to dispatch_queue_create for media type processing queues 2013-02-04 00:41:13 +01:00
Mattt Thompson
136f5ab1b9 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2013-02-04 00:21:54 +01:00
Mattt Thompson
fa3a77544f Ignoring -Wcovered-switch-default in AFHTTPBodyPart -hasBytesAvailable 2013-02-04 00:21:42 +01:00
Mattt Thompson
321a2af79d Fixing warnings caused by implicit property attributes 2013-02-04 00:20:56 +01:00
Mattt Thompson
dd529c9c12 Merge pull request #772 from 0xced/fix-uiimageview-nil-url
Compare NSURLRequest rather than NSURL
2013-02-03 15:12:57 -08:00
Mattt Thompson
447fb3a913 Adding lock around AFURLConnectionOperation -responseStringEncoding
Adding check for self.response in AFURLConnectionOperation -responseStringEncoding
2013-02-04 00:01:14 +01:00
Mattt Thompson
9b16005f4e Adding lock around AFHTTPRequestOperation -responseString 2013-02-04 00:00:25 +01:00
Mattt Thompson
af8ca5af92 Merge branch 'experimental-issue-737'
Conflicts:
	AFNetworking/AFHTTPClient.m
2013-02-01 22:44:16 +00:00
Mattt Thompson
9ae534b94f Limiting default Accept-Language header to 6 languages 2013-02-01 22:43:30 +00:00
Cédric Luthi
4b17ec6b51 Compare NSURLRequest rather than NSURL
If you inadvertently load a nil URL in UIImageView+AFNetworking, the failure block of the image request operation is bypassed because [nil isEqual:nil] == NO. By comparing the URL request instead of the URL, the `isEqual:` test passes and the error is properly forwarded to the failure block parameter.
2013-02-01 12:23:26 +01:00
Oliver Jones
22c7d4ec96 Fixes warning: weak receiver may be unpredictably set to nil [-Wreceiver-is-weak]
Signed-off-by: Mattt Thompson <m@mattt.me>
2013-02-01 02:45:36 +00:00
Oliver Jones
8558d4d5f0 Fixes warning: multiple methods named 'objectForKey:' found [-Wstrict-selector-match] 2013-02-01 02:43:12 +00:00
Oliver Jones
6b8cdf1581 Fixes warning: multiple methods named 'postNotificationName:object:' found [-Wstrict-selector-match] 2013-02-01 02:42:58 +00:00
Mattt Thompson
74da4493f2 Wrapping AFHTTPBodyPart switch statement with #pragma to ignore -Wcovered-switch-default 2013-02-01 02:39:02 +00:00
Mattt Thompson
be72f5fe1f [Issue #767] Consolidating macros 2013-01-31 07:06:26 +00:00
Mattt Thompson
26da1ad95a Merge branch 'master' of https://github.com/Fl0p/AFNetworking into Fl0p-master 2013-01-31 07:02:51 +00:00
Mattt Thompson
e969fcd904 Cleaning up formatting from pull request
Adding @dynamic for lock property
2013-01-31 07:00:03 +00:00
Mattt Thompson
3efe3742f1 Merge pull request #768 from jparise/response-json-lock
Serialize calls to responseJSON using a lock.
2013-01-30 22:56:53 -08:00
Mattt Thompson
c790135fd4 Updating OS X project settings 2013-01-31 06:55:04 +00:00
Mattt Thompson
0f794ccfc9 [Issue #769] Resolving asymmetry in cached image case for UIImageView category 2013-01-31 06:54:45 +00:00
Jon Parise
0dbff8387b Serialize calls to responseJSON using a lock.
AFJSONRequestOperation's completion path calls `responseJSON` from a
processing queue.  Because `responseJSON` "lazily" deserializes the
response data into a JSON object, it needs to be protected against
concurrent access from other queues (threads).

For example, `AFNetworkingOperationDidFinishNotification` is posted
when the operation finishes but perhaps before that processing queue
has finishing executing.  Notification observers who also access
`responseJSON` end up in a race with that queue that often leads to a
crash.

We reuse the existing lock from our AFURLConnectionOperation base
class.
2013-01-30 12:25:22 -08:00
flop
d998515d24 Fix [Issue #751] 2013-01-30 21:52:13 +03:00
Mattt Thompson
eac6ffbb6e Revert "Fixing warning caused by default statement in switch statement that covered all enumeration values"
This reverts commit b5c48f13a1.
2013-01-30 16:25:56 +00:00
Mattt Thompson
b5c48f13a1 Fixing warning caused by default statement in switch statement that covered all enumeration values 2013-01-29 15:31:16 +00:00
Mattt Thompson
b70be414b7 Fixing @param name to correspond to actual parameter (filename -> fileName) 2013-01-29 15:31:12 +00:00