Commit graph

984 commits

Author SHA1 Message Date
Daniel Tull
7134e9612f Cause a failure when an operation is cancelled, fixes #657 2012-12-19 14:47:49 +00:00
Mattt Thompson
a146a3bf66 Merge pull request #685 from dongle/master
Added assertion for empty body data in -appendPartWithHeaders:body:
2012-12-17 11:14:06 -08:00
Jonathan Beilin
fa0fc535a1 Adding assertion for empty data in -appendPartWithHeaders:body: 2012-12-17 10:31:00 -08:00
Mattt Thompson
0f35164082 Merge branch 'fixes-for-strict-warnings' of https://github.com/ittybittyapps/AFNetworking into ittybittyapps-fixes-for-strict-warnings
Conflicts:
	AFNetworking/AFHTTPClient.m
	AFNetworking/AFHTTPRequestOperation.m
	AFNetworking/AFImageRequestOperation.h
	AFNetworking/AFNetworking.h
	AFNetworking/AFURLConnectionOperation.m
2012-11-30 15:09:11 -08:00
Sebastian Ludwig
d3cb65c087 [Issue #651] Adding workaround for Rails behavior of returning a single space in head :ok responses, which is interpreted as invalid input by NSJSONSerialization
Signed-off-by: Mattt Thompson <m@mattt.me>
2012-11-30 14:40:53 -08:00
Basil Shkara
99c58dcf08 [Issue #652] Adding early return in -startMonitoringNetworkReachability if network reachability object could not be created (i.e. invalid hostnames)
Signed-off-by: Mattt Thompson <m@mattt.me>
2012-11-30 14:22:05 -08:00
Mathijs Kadijk
09cf2d39e2 [Issue #660] Add workaround for NSJSONSerialization crash with Unicode character escapes in JSON response
Signed-off-by: Mattt Thompson <m@mattt.me>
2012-11-30 14:12:59 -08:00
Mattt Thompson
607e91b5b8 Adding responseStringEncoding property to AFURLConnectionOperation 2012-11-30 14:11:59 -08:00
Mattt Thompson
eaa1252d40 Adding top-level group for source files 2012-11-30 13:37:07 -08:00
Oliver Jones
d38895e5d8 Fixes warning: enumeration value 'AFFinalBoundaryPhase' not explicitly handled in switch [-Werror,-Wswitch-enum] 2012-11-30 18:14:26 +11:00
Oliver Jones
b64c6bd846 Fixes warning: atomic by default property 'X' has a user defined getter (property should be marked 'atomic' if this is intended) [-Werror,-Wcustom-atomic-properties] 2012-11-30 18:13:43 +11:00
Oliver Jones
b75c673a2c Fixes warning: 'X' is not defined, evaluates to 0 [-Werror,-Wundef] 2012-11-30 18:12:47 +11:00
Oliver Jones
692f7126ca Fixes warning: 'response' was marked unused but was used [-Werror,-Wused-but-marked-unused] 2012-11-30 18:04:44 +11:00
Oliver Jones
72ab802a2d Fixes warning: atomic by default property 'X' has a user defined getter (property should be marked 'atomic' if this is intended) [-Werror,-Wcustom-atomic-properties] 2012-11-30 18:02:15 +11:00
Oliver Jones
d8b4dcb349 Fixes warning: 'macro' is not defined, evaluates to 0 2012-11-30 17:59:50 +11:00
Oliver Jones
f4d25341cf Fixing tabs/spaces whitespace inconsistency. 2012-11-29 19:08:41 +11:00
Oliver Jones
3997dbb7e9 Fixes warning: multiple methods named 'selector' found [-Werror,-Wstrict-selector-match] 2012-11-29 18:46:04 +11:00
Oliver Jones
23b8fe33ba Fixes warning: weak receiver may be unpredictably null in ARC mode [-Werror,-Wreceiver-is-weak] 2012-11-29 18:30:28 +11:00
Oliver Jones
f9449753ff Fixes warning: property is assumed atomic by default [-Werror,-Wimplicit-atomic-properties] 2012-11-29 18:06:05 +11:00
Oliver Jones
debd442903 Fixes warning: unused parameter 'x' [-Werror,-Wunused-parameter] 2012-11-29 18:03:34 +11:00
Oliver Jones
3486a008a1 Fixing warnings: implicit conversion changes signedness: 'NSInteger' (aka 'long') to 'unsigned long' [-Werror,-Wsign-conversion] 2012-11-29 17:53:30 +11:00
Mattt Thompson
402e460023 Changing order of conditional check to match responseString 2012-11-15 10:20:21 -08:00
Mattt Thompson
92134e92c3 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-11-15 10:10:48 -08:00
Mattt Thompson
000010f850 Adding missing scan of '/' separator in content type string 2012-11-15 10:05:55 -08:00
Jorge Bernal
db8941f1ba [Issue #638] Following guidelines from RFC 2616 regarding the use of string encoding when none is specified in the response
Signed-off-by: Mattt Thompson <m@mattt.me>
2012-11-15 09:53:53 -08:00
Mattt Thompson
7c76df739f Merge pull request #644 from 0xced/localization-table
Use NSLocalizedStringFromTable with AFNetworking.strings table
2012-11-15 09:12:54 -08:00
Cédric Luthi
f106d19536 Use NSLocalizedStringFromTable with AFNetworking.strings table for localized strings 2012-11-14 17:44:11 +01:00
Mattt Thompson
eaac6a1759 [Issue #640] Removing documentation note about default Accept-Encoding header 2012-11-12 21:44:29 -08:00
Mattt Thompson
247863cfc2 [Issue #633] Manually casting scalar types in initWithCoder for AFURLConnectionOperation and AFHTTPClient 2012-11-09 07:31:53 -08:00
Mattt Thompson
ff8e70a49c Using addOperations:waitUntilFinished: instead of adding each operation individually in -enqueueBatchOfHTTPRequestOperations:... to fix an edge case bug where only one of the operations in a batch will run. 2012-11-06 12:03:19 -08:00
Mattt Thompson
24dfebb424 Merge branch 'master' of github.com:AFNetworking/AFNetworking 2012-11-06 09:22:04 -08:00
Mattt Thompson
5ec794dc4d Indenting macro conditionals 2012-11-06 09:21:41 -08:00
Mattt Thompson
d5bd23ca17 Distinguisging between CoreServices and MobileCoreServices for #warning 2012-11-06 09:13:22 -08:00
Mattt Thompson
a495902c65 Removing quotes for #warning macros 2012-11-06 09:10:22 -08:00
Mattt Thompson
adda25dd3c Merge pull request #629 from 0xced/field-escaping-description
Derive keys string representations using the description method
2012-11-06 08:37:05 -08:00
Cédric Luthi
db10b25bb2 Derive keys string representations using the description method as specified in AFQueryStringFromParametersWithEncoding documentation 2012-11-06 15:16:48 +01:00
Mattt Thompson
f62e5cf6f3 Update CHANGES 2012-11-05 13:08:55 -08:00
Mattt Thompson
97dd5602f6 Merge pull request #627 from apoltix/master
[Issue #624] Moved __unused keywords for better Xcode indexing
2012-11-05 13:06:04 -08:00
Christian Rasmussen
940f42dade [#624] Moved __unused keywords for better Xcode indexing. 2012-11-05 21:33:56 +01:00
Mattt Thompson
fd157cb7de Adding chanelog item for 5b32b45 2012-11-05 12:05:58 -08:00
Mattt Thompson
5b32b45469 [Issue #619] Sorting dictionary keys with caseInsensitiveCompare to ensure deterministic ordering of query string parameters, which may otherwise cause ambiguous representations of nested parameters 2012-11-05 12:03:23 -08:00
Mattt Thompson
9cde4e4584 Adding release notes for 1.0.1 2012-11-01 08:56:17 -07:00
Mattt Thompson
8603f8f653 Update CHANGES 2012-11-01 08:49:03 -07:00
Mattt Thompson
6f64dc2b65 Merge pull request #617 from tewha/master
Document change in CHANGES
2012-11-01 08:46:54 -07:00
Mattt Thompson
aab0ceec08 Merge pull request #618 from lxcid/master
[Issue #591] Attempts to fix crash caused by incorrect calculation of range when reading data into buffer.
2012-11-01 08:36:03 -07:00
Stan Chang Khin Boon
2fde59c3fd [Issue #591] Attempts to fix crash caused by incorrect calculation of range when reading data into buffer.
When the current buffer isn't large enough to store the data,
AFNetworking attempts to fill the current buffer with as much data as
it can holds and leaves the remaining data to the next buffer.

There is a bug when calculating the range to read from data in the next
buffer. The `_phaseReadOffset` is set correctly but the `[data length]`
is not adjusting correctly to the offset. This causes `getBytes:range:`
to complains that it attempts to get bytes that are out of range.

An attempted fix is done here by adjusting the range (Also adjust to
check against `_phaseReadOffset` instead of `range.length`.

As I am modifying some critical section, a detail review might be
required.

I am sending this pull request so as to facilitiate the review process,
but if you are already in review of the issue and the solution, you can
ignore my pull and close it. Thanks!

Detail explanation of how the solution come about can be found here:
https://github.com/AFNetworking/AFNetworking/issues/591#issuecomment-993
0763
2012-11-01 02:42:14 +08:00
Steven Fisher
9c34a68fba Document change for next version. 2012-10-31 10:21:43 -07:00
Mattt Thompson
e2f2ab45aa [Issue #599] Refactoring AFHTTPClient to remove unnecessary JSON / plist serialization functions, logging any error that may arise. 2012-10-31 09:55:18 -07:00
Mattt Thompson
175c3fa451 [Issue #565] Checking for kCFStringEncodingInvalidId from CFStringConvertIANACharSetNameToEncoding() before getting NSStringEncoding with CFStringConvertEncodingToNSStringEncoding, which may otherwise lead to unexpected behavior 2012-10-31 08:37:47 -07:00
Mattt Thompson
d31e23af29 [Issue #603] Removing duplicated runloop scheduling of outputStream 2012-10-31 08:27:10 -07:00